GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152168: Don't skip `test_bigmem` if `_testcapi` is missing by ShaharNaveh · Pull Request #152171 · python/cpython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: All tests in test_bigmem.py are skipped if _testcapi is not available #152168

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShaharNaveh
Don't skip test_bigmem if _testcapi is missing
7f0b2e3
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2026
All tests in test_bigmem.py are skipped if _testcapi is not available #152168
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 25, 2026
@StanFromIreland StanFromIreland added the skip news label Jun 25, 2026
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

!buildbot bigmem
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 7f0b2e3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152171%2Fmerge

The command will test the builders whose names match following regular expression: bigmem

The builders matched are:

  • aarch64 Ubuntu 24.04 BigMem PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland self-assigned this Jun 25, 2026
@ShaharNaveh

ShaharNaveh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

test failures seems unrelated, right? 😕
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

Don't worry, I've been playing the TSan lottery all week 🙃 I have a PR to skip it.
ShaharNaveh reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

The test_zipfile64 fail on the buildbot is #152190, test_bigmem passes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland approved these changes Jun 25, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 25, 2026
@StanFromIreland StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 25, 2026
@StanFromIreland
StanFromIreland merged commit 6a82832 into python:main Jun 25, 2026
103 of 106 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks @ShaharNaveh for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 25, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Sorry, @ShaharNaveh and @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6a82832a0bd12ff6154fcfcccc3b7b5644eab0e8 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152198 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152199 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed needs backport to 3.15 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 25, 2026
@StanFromIreland StanFromIreland removed the needs backport to 3.13 only security fixes label Jun 25, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington @ShaharNaveh
[3.15] gh-152168: Don't skip test_bigmem if _testcapi is missing (G…
06e6515 
…H-152171) (#152198)

(cherry picked from commit 6a82832)

Co-authored-by: Shahar Naveh <[email protected]>
StanFromIreland pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington @ShaharNaveh
[3.14] gh-152168: Don't skip test_bigmem if _testcapi is missing (G…
a1e057b 
…H-152171) (#152199)

(cherry picked from commit 6a82832)

Co-authored-by: Shahar Naveh <[email protected]>
@ShaharNaveh ShaharNaveh mentioned this pull request Jun 26, 2026
Don't require _testcapi and _testinternalcapi for test_monitoring.py #152311
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@StanFromIreland StanFromIreland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ShaharNaveh @StanFromIreland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.