GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-98894: Skip dtrace tests when building without dtrace by stratakis · Pull Request #152239 · python/cpython Conversation
|
|
cc @vstinner |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
On a Python built without
Hum, I'm not sure that it's worth it to run this single test on a Python built without Instead, I suggest running the check at the module top-level and remove the check from CheckDtraceProbes.setUpClass(). Something like: if not support.has_subprocess_support: raise unittest.SkipTest("test module requires subprocess") if not sysconfig.get_config_var('WITH_DTRACE'): raise unittest.SkipTest( "CPython must be configured with the --with-dtrace option." ) So the whole test is skipped: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I prefer this simpler change!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Note: try to avoid |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-152300 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-152301 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-152302 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.