GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98894: Skip dtrace tests when building without dtrace by stratakis · Pull Request #152239 · python/cpython

Conversation

@stratakis

@stratakis stratakis commented Jun 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skip functional test_dtrace cases when CPython was not configured with --with-dtrace.

  • Issue: Some DTrace probes are broken in 3.11 #98894

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2026
Some DTrace probes are broken in 3.11 #98894
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jun 26, 2026
@stratakis

stratakis commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

cc @vstinner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jun 26, 2026

Copy link
Copy Markdown
Member

On a Python built without --with-dtrace, test_dtrace runs exactly one function:

test_filter_probe_rows_ignores_warnings (test.test_dtrace.BPFTraceOutputTests.test_filter_probe_rows_ignores_warnings) ... ok

Hum, I'm not sure that it's worth it to run this single test on a Python built without --with-dtrace.

Instead, I suggest running the check at the module top-level and remove the check from CheckDtraceProbes.setUpClass().

Something like:

if not support.has_subprocess_support:
    raise unittest.SkipTest("test module requires subprocess")
if not sysconfig.get_config_var('WITH_DTRACE'):
    raise unittest.SkipTest(
        "CPython must be configured with the --with-dtrace option."
    )

So the whole test is skipped:

0:00:00 load avg: 0.72 mem: 29.9 MiB [1/1] test_dtrace
test_dtrace skipped -- CPython must be configured with the --with-dtrace option.
0:00:00 load avg: 0.72 mem: 31.0 MiB [1/1] test_dtrace skipped
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 26, 2026
@stratakis
pythongh-98894: Skip dtrace tests when building without dtrace
4e23d32
@stratakis
stratakis force-pushed the gate_dtrace branch from 0f33a52 to 4e23d32 Compare June 26, 2026 14:18
vstinner
vstinner approved these changes Jun 26, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I prefer this simpler change!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 26, 2026
@vstinner

vstinner commented Jun 26, 2026

Copy link
Copy Markdown
Member

Note: try to avoid git push --force, it makes reviews harder to follow.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner enabled auto-merge (squash) June 26, 2026 14:25
@vstinner
vstinner merged commit 6713576 into python:main Jun 26, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152300 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152301 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152302 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 26, 2026
vstinner pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @stratakis
[3.14] gh-98894: Skip test_dtrace when building without dtrace (GH-15…
e7b7d58
…2239) (#152301)

gh-98894: Skip test_dtrace when building without dtrace (GH-152239)
(cherry picked from commit 6713576)

Co-authored-by: stratakis <[email protected]>
vstinner pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @stratakis
[3.15] gh-98894: Skip test_dtrace when building without dtrace (GH-15…
d19b93a
…2239) (#152300)

gh-98894: Skip test_dtrace when building without dtrace (GH-152239)
(cherry picked from commit 6713576)

Co-authored-by: stratakis <[email protected]>
vstinner pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @stratakis
[3.13] gh-98894: Skip test_dtrace when building without dtrace (GH-15…
26ccc73
…2239) (#152302)

gh-98894: Skip test_dtrace when building without dtrace (GH-152239)
(cherry picked from commit 6713576)

Co-authored-by: stratakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@stratakis @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.