GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152375: Fix UB in `INSTRUMENTED_JUMP` by StanFromIreland · Pull Request #152376 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I didn't add a test, I think it's too messy here, but I don't feel strongly about it. It is also already covered (non-deterministically) by test_monitoring, as that's what triggered UBSan.

  • Issue: Pointer arithmetic on NULL in INSTRUMENTED_JUMP #152375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
Fix UB in INSTRUMENTED_JUMP
452407b
@StanFromIreland
StanFromIreland requested a review from markshannon as a code owner June 27, 2026 09:08
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2026
Pointer arithmetic on NULL in INSTRUMENTED_JUMP #152375
Closed
@StanFromIreland

This comment was marked as off-topic.

Sign in to view
This was referenced Jun 27, 2026
Add curses.scr_dump(), scr_restore(), scr_init() and scr_set() #152260
Closed
Don't require _testcapi and _testinternalcapi for test_monitoring.py #152311
Merged
@StanFromIreland
Merge branch 'main' into INSTRUMENTED_JUMP-ub
9110586
@serhiy-storchaka

This comment was marked as off-topic.

Sign in to view
@StanFromIreland
StanFromIreland requested a review from iritkatriel June 27, 2026 11:47
iritkatriel
iritkatriel reviewed Jun 27, 2026
View reviewed changes
Comment thread Python/ceval_macros.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland requested a review from iritkatriel June 27, 2026 12:47
iritkatriel
iritkatriel approved these changes Jun 27, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 27, 2026
@StanFromIreland StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 27, 2026
@StanFromIreland
StanFromIreland merged commit cdec9ac into python:main Jun 29, 2026
69 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland deleted the INSTRUMENTED_JUMP-ub branch June 29, 2026 09:06
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 29, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152566 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdec9acd63c33d9b822700de8f63eb94d86e1c93 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 29, 2026
@miss-islington-app miss-islington-app Bot assigned StanFromIreland Jun 29, 2026
@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152567 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2026
@StanFromIreland

StanFromIreland commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@miss-islington @StanFromIreland
[3.14] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
be68d9a 
…macro (GH-152376) (#152567)

(cherry picked from commit cdec9ac)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152577 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 29, 2026
StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@miss-islington @StanFromIreland
[3.15] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
00a4304 
…macro (GH-152376) (#152566)

(cherry picked from commit cdec9ac)

Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@StanFromIreland
[3.13] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
1638151 
…macro (GH-152376) (#152577)

(cherry picked from commit cdec9ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@StanFromIreland StanFromIreland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @serhiy-storchaka @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.