GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — gh-152356: Fix Windows blocking sampling after target process exit by zainnadeem786 · Pull Request #152471 · python/cpython Conversation
Contributor
SummaryFixes gh-152356. On Windows, The non-blocking sampling path already terminates correctly when the target exits, but the Windows blocking implementation classified the same process-exit condition differently. Root CauseDuring blocking sampling, the profiler pauses the target through the Windows remote debugging layer. If the target process has already exited, The sampling loop treats Other platforms already report terminated processes as ChangesThis patch updates the Windows implementation of When Existing No other profiling behaviour changes. TestsAdded a Windows-only regression test that:
ValidationValidated with:
After this change, Windows blocking sampling terminates correctly once the target process exits and produces a valid replayable binary profile.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
pablogsal
reviewed
Uh oh!
There was an error while loading. Please reload this page.
zainnadeem786
force-pushed
the
fix/profiling-sampling-blocking-windows-exit
branch
from
c972652 to
42f0941
Compare
pablogsal
approved these changes
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
pablogsal
enabled auto-merge (squash)
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. profiling.sampling run --blocking hangs and writes an empty profile on WindowsUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |