GeezerVison

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

LGTM considering @zooba's #152433 (comment).

cc @colesbury who tracks mimalloc differences from upstream in #113141.

This change looks fine, if we're maintaining the sources separately. If we're trying to track upstream closely, then we'll need them to make the change first. That's @colesbury's call, it seems.

Our copy of mimalloc is fairly out of date at this point, and does carry several patches against the equivalent upstream version. Regardless, I think we should be sure that this is done upstream before we merge it ourselves, or it's likely to be lost if and when we update our copy -- ideally, when we do such an update we can do it without carrying any patches forward.

Yeah, if it's not CPython specific, please also open a PR in upstream mimalloc.

Patch submitted to upstream (microsoft/mimalloc#1340).

Note is a bit different because GetNumaHighestNodeNumber thing is already addressed in current version and only replaced LoadLibrary for better code portability (to very old Windows versions).

I think PR can still be merged here because it doesn't do any harm and in the future it will be overwritten by whatever is upstream.

The fix has been merged in the mimalloc dev branch:
microsoft/mimalloc@c9c86c7

May I trouble you to make this PR look closer to the diff that has been merged upstream?

For instance, there GetProcessMemoryInfo is still only loaded on demand - now via mi_win_loadlibrary(TEXT("psapi.dll")), but this PR currently removes the loading on demand.

PR updated with almost same commit that upstream.

I tested the updated PR on Xbox and not even compiles due a missing header 😒

PR updated with the fix.

(the header was already present in the first version of the PR)

Finally found that LoadLibrary can be used on UWP for system libs from Windows SDK 10.0.22000.0.

And most changes are not necessary 😊

This PR is sitting for a while now and lgtm. If nobody objects, I'm gonna merge end of next week at the latest.

Looked good to me too, so figured no reason to wait