GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152563, test_math: Enable fma test on musl 1.2.6 by weixlu · Pull Request #152564 · python/cpython

Conversation

@weixlu

@weixlu weixlu commented Jun 29, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Proposal:

#131313 fix many tests on Alpine Linux (musl C library). About test_fma_zero_result, it says

    # gh-131032: musl is fixed but the fix is not yet released; when the fixed
    # version is known change this to:
    #   or support.linked_to_musl() < (1, <m>, <p>)

And now musl 1.2.6 is available, and I have verified that the test can pass. So let's enable it.

  • docker image: alpine:edge
  • musl version: 1.2.6-r2
  • test result: pass

I also test the older version

  • docker image: alpine:3.21
  • musl version: 1.2.5-r11
  • test result: skipped
  • Issue: Enable fma test on Alpine Linux (musl C library) #152563

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 29, 2026
@bedevere-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot added the awaiting review label Jun 29, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 29, 2026
Enable fma test on Alpine Linux (musl C library) #152563
Closed
@weixlu
pythongh-152563: Enable fma test on Alpine Linux (musl C library)
539c04e
@weixlu
weixlu force-pushed the fma branch from 97696e0 to 539c04e Compare June 29, 2026 09:13
@bedevere-app

This comment was marked as duplicate.

Sign in to view
@StanFromIreland StanFromIreland added the skip news label Jun 29, 2026
@StanFromIreland
StanFromIreland requested review from bitdancer and vstinner and removed request for vstinner June 29, 2026 09:34
@vstinner

vstinner commented Jun 29, 2026

Copy link
Copy Markdown
Member

image: alpine:edge
musl version: 1.2.6-r2
test result: pass

I just tested podman run --rm --interactive --tty alpine:edge: I still get musl 1.2.5.

~ # apk info musl
(...)
musl-1.2.5-r21 description:
the musl c library (libc) implementation

musl-1.2.5-r21 webpage:
https://musl.libc.org/

musl-1.2.5-r21 installed size:
650 KiB

I would prefer to wait until musl 1.2.6 final is released and available in Alpine Linux.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner changed the title gh-152563: Enable fma test on Alpine Linux (musl C library) gh-152563, test_math: Enable fma test on musl 1.2.6 Jun 29, 2026
@weixlu

weixlu commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner Thanks for the review. Yes, I just double-checked and alpine:edge still defaults to musl-1.2.5. I previously ran apk add --no-cache musl-dev, that's why I got 1.2.6-r2.

I would prefer to wait until musl 1.2.6 final is released and available in Alpine Linux.

No problem, let's wait until 1.2.6 is officially included in the default version.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Aug 10, 2026

Copy link
Copy Markdown
Member

https://musl.libc.org/releases.html tells me that musl 1.2.6 was released in March 20, 2026.

No problem, let's wait until 1.2.6 is officially included in the default version.

@weixlu: Hi. Can you check if it's the case now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@weixlu

weixlu commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner Ah yes, thanks for reminder. I have verified that musl 1.2.6 is now officially included

$ docker run --rm alpine:edge apk info musl

musl-1.2.6-r2 description:
the musl c library (libc) implementation

musl-1.2.6-r2 webpage:
https://musl.libc.org/

musl-1.2.6-r2 installed size:
706 KiB

Also I've run test_math and it looks good. So I think this PR is ready to go

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner approved these changes Aug 11, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that all FMA tests of test_math pass on the latest Alpine Linux with musl-1.2.6-r2.

~/cpython # apk info musl
musl-1.2.6-r2 description:
the musl c library (libc) implementation

musl-1.2.6-r2 webpage:
https://musl.libc.org/

musl-1.2.6-r2 installed size:
654 KiB

~/cpython # ./python
Python 3.16.0a0 (heads/main:fcfa919, Aug 11 2026, 13:30:35) [GCC 15.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from test import support
>>> support.linked_to_musl()
(1, 2, 6)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

weixlu reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 11, 2026
@vstinner

vstinner commented Aug 11, 2026

Copy link
Copy Markdown
Member

cc @zware @bitdancer

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 5ea3935 into python:main Aug 13, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 13, 2026
@vstinner vstinner added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 13, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155753 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 13, 2026
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155754 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2026
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155755 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 13, 2026
@vstinner

vstinner commented Aug 13, 2026

Copy link
Copy Markdown
Member

Merged, thanks for the change.

weixlu reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner pushed a commit that referenced this pull request Aug 13, 2026
@miss-islington @weixlu
[3.13] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
8e85d73
#155753)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <[email protected]>
vstinner pushed a commit that referenced this pull request Aug 13, 2026
@miss-islington @weixlu
[3.14] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
4e9ec0a
#155754)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <[email protected]>
hugovk pushed a commit that referenced this pull request Aug 14, 2026
@miss-islington @weixlu
[3.15] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
7533d8a
#155755)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <[email protected]>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@weixlu @mbeijen
pythongh-152563, test_math: Enable fma test on musl 1.2.6 (python#152564
0eee29c
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@bitdancer bitdancer Awaiting requested review from bitdancer

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@weixlu @vstinner @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.