GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: allow build socketmodule for UWP by thexai · Pull Request #152601 · python/cpython

Conversation

@thexai

@thexai thexai commented Jun 29, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: allow build socketmodule for UWP.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jun 29, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jun 29, 2026
@thexai
thexai force-pushed the uwp-socketmodule branch 2 times, most recently from 5f2d937 to 24d340b Compare June 30, 2026 15:07
@thexai
thexai force-pushed the uwp-socketmodule branch from 24d340b to 280929d Compare July 15, 2026 14:20
@thexai

thexai commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and resolved merge conflict.
moritajavier239-rgb reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl
chris-eibl approved these changes Jul 18, 2026
View reviewed changes

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 18, 2026
@thexai
thexai force-pushed the uwp-socketmodule branch from 280929d to 16f6d41 Compare August 19, 2026 09:04
@thexai

thexai commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to resolve merge conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thexai
pythongh-152433: Windows: allow build socketmodule for UWP
1b7b242
@thexai
thexai force-pushed the uwp-socketmodule branch from 16f6d41 to 1b7b242 Compare September 5, 2026 08:16
@chris-eibl

chris-eibl commented Sep 5, 2026

Copy link
Copy Markdown
Member

@thexai: please don't force push, this makes incremental reviews so much harder. See also our devguide.

This PR still lgtm and is sitting for a while now. If nobody objects, I'm gonna merge end of next week at the latest.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thexai

thexai commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and force pushed due merge conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl

chris-eibl commented Sep 5, 2026

Copy link
Copy Markdown
Member

Yupp, rebase is fine when there are merge conflicts, but can still be done without force pushing, which is much preferred here.
thexai reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl
chris-eibl merged commit 77dd973 into python:main Sep 11, 2026
98 of 100 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 11, 2026
@thexai
thexai deleted the uwp-socketmodule branch September 11, 2026 06:32
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
@thexai @clin1234
pythongh-152433: Windows: allow build socketmodule for UWP (python#15…
26ba2f5 
…2601)
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@thexai @johnslavik
pythongh-152433: Windows: allow build socketmodule for UWP (python#15…
5e8808b 
…2601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thexai @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.