GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-151987: Pass filter_function to TarFile._extract_one() during .extract() (GH-151988) by miss-islington · Pull Request #152613 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 29, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 7ccdbab)

Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Seth Michael Larson [email protected]

  • Issue: Tarfile.extract doesn't fully respect the filter parameter #151987

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou @sethmlarson @miss-islington
pythongh-151987: Pass filter_function to TarFile._extract_one() durin…
1924e21 
…g .extract() (pythonGH-151988)

(cherry picked from commit 7ccdbab)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
@miss-islington
miss-islington requested a review from ethanfurman as a code owner June 29, 2026 15:42
This was referenced Jun 29, 2026
Tarfile.extract doesn't fully respect the filter parameter #151987
Closed
gh-151987: Pass filter_function to TarFile._extract_one() during .extract() #151988
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 29, 2026
@encukou encukou added the type-security A security issue label Jun 30, 2026
@StanFromIreland StanFromIreland assigned pablogsal Jul 3, 2026
@pablogsal

pablogsal commented Jul 4, 2026

Copy link
Copy Markdown
Member

@encukou this is breaking tests in 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Remove newer test helpers
551fa51 
3.11+ has more granular platform support, mostly for WASI.
Use the 3.10 idioms instead:

- @symlink_test is a no-op on non-WASI platforms
- can_chmod is approximated by "not win32" elsewhere in test_tarfile
@encukou

encukou commented Jul 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for the catch!
The MacOS failure is unrelated and common to recent 3.11 & 3.10 PRs. See #100373 for a discussion.
pablogsal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit cf23b91 into python:3.10 Jul 11, 2026
27 of 31 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 11, 2026
@miss-islington
miss-islington deleted the backport-7ccdbab-3.10 branch July 11, 2026 17:45
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
@miss-islington @encukou
@sethmlarson @icanhasmath
[3.10] pythongh-151987: Pass filter_function to TarFile._extract_one(…
328e33f 
…) during .extract() (pythonGH-151988) (python#152613)

* pythongh-151987: Pass filter_function to TarFile._extract_one() during .extract() (pythonGH-151988)

(cherry picked from commit 7ccdbab)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>

* Remove newer test helpers

3.11+ has more granular platform support, mostly for WASI.
Use the 3.10 idioms instead:

- @symlink_test is a no-op on non-WASI platforms
- can_chmod is approximated by "not win32" elsewhere in test_tarfile

---------

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
(cherry picked from commit cf23b91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @pablogsal @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.