GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: allow build ``ceval.c`` for UWP by thexai · Pull Request #152689 · python/cpython

Conversation

@thexai

@thexai thexai commented Jun 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: allow build ceval.c for UWP.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai
thexai requested a review from markshannon as a code owner June 30, 2026 14:10
@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jun 30, 2026
chris-eibl
chris-eibl reviewed Jun 30, 2026
View reviewed changes
Comment thread Python/ceval.c
GetCurrentThreadStackLimits(&low, &high);
*top = (uintptr_t)high;
ULONG guarantee = 0;
#ifdef MS_WINDOWS_DESKTOP

@chris-eibl chris-eibl Jun 30, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, since SetThreadStackGuarantee isn't available for UWP, we can't use it here, but since

Sets the minimum size of the stack associated with the calling thread or fiber that will be available during any stack overflow exceptions. This is useful for handling stack overflow exceptions; the application can safely use the specified number of bytes during exception handling.

we'd lose that in case of UWP :(

I think this ok, cc @markshannon?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai
pythongh-152433: Windows: allow build ceval.c for UWP
2b6aff0
@thexai
thexai force-pushed the uwp-ceval branch from 62d3577 to 2b6aff0 Compare July 4, 2026 18:12
@thexai thexai changed the title gh-152433: Windows: ceval.c allow build in UWP gh-152433: Windows: allow build ceval.c for UWP Jul 4, 2026
chris-eibl
chris-eibl approved these changes Sep 5, 2026
View reviewed changes

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sitting for a while now. If nobody objects, I'm gonna merge end of next week at the latest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thexai reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 5, 2026
@chris-eibl
chris-eibl merged commit 1b1b9b3 into python:main Sep 11, 2026
63 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 11, 2026
@thexai
thexai deleted the uwp-ceval branch September 11, 2026 10:43
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
@thexai @clin1234
pythongh-152433: Windows: allow build ceval.c for UWP (python#152689
1782684 
)
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@thexai @johnslavik
pythongh-152433: Windows: allow build ceval.c for UWP (python#152689
5bf9d6b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thexai @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.