GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: ``_ssl`` module: improve UWP compatibility by thexai · Pull Request #152791 · python/cpython

Conversation

@thexai

@thexai thexai commented Jul 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: _ssl module: improve UWP compatibility.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai
thexai requested review from a team, gpshead and picnixz as code owners July 1, 2026 14:41
@bedevere-app bedevere-app Bot mentioned this pull request Jul 1, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jul 1, 2026
picnixz
picnixz reviewed Jul 1, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please use if defined() and elif defined(MS_WINDOWS) && ... and else for the fallback branch.
  • Can you determine why we are only raising a NotImplementedError on MS DEBUG builds for those functions? it's a separate issue but I think we should also raise unconditionally (or does it mean that those functions are available on regular MS builds only in release builds?) If there is something worth investigating, you can open a separate issue for that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_ssl/debughelpers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_ssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thexai
thexai force-pushed the uwp-_ssl branch 2 times, most recently from 834b4c3 to 4db23b3 Compare July 3, 2026 14:42
picnixz
picnixz reviewed Jul 3, 2026
View reviewed changes
Comment thread Modules/_ssl/debughelpers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thexai
thexai force-pushed the uwp-_ssl branch from 4db23b3 to db95409 Compare July 3, 2026 15:36
picnixz
picnixz approved these changes Jul 3, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 3, 2026
picnixz
picnixz reviewed Jul 3, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2026-07-01-16-38-24.gh-issue-152433.jvEiHh.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thexai
pythongh-152433: Windows: _ssl module: improve UWP compatibility
72caa80
@thexai
thexai force-pushed the uwp-_ssl branch from db95409 to 72caa80 Compare July 3, 2026 15:51
picnixz
picnixz approved these changes Jul 3, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was small enough and changes were easy to spot, but in the future, please avoid force pushing once someone started reviewing your PR as it makes incremental review much harder. We squash merge at the end and change the commit messages ourselves when necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai thexai closed this Jul 4, 2026
@thexai thexai reopened this Jul 4, 2026
@zooba zooba added the needs backport to 3.15 bugs and security fixes label Jul 6, 2026
@zooba
zooba merged commit 4221ce7 into python:main Jul 6, 2026
103 of 105 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

Thanks @thexai for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 6, 2026
@bedevere-app

bedevere-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

GH-153216 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 6, 2026
thexai added a commit to thexai/cpython that referenced this pull request Jul 17, 2026
@thexai
pythongh-152433: Allow _ssl module to build for Windows UWP API set (p…
2f58162 
…ythonGH-152791)
@thexai
thexai deleted the uwp-_ssl branch July 19, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments
@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@thexai @zooba @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.