GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: allow ``posixmodule.c`` to build for Windows UWP by thexai · Pull Request #152998 · python/cpython

Conversation

@thexai

@thexai thexai commented Jul 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: allow posixmodule.c to build for Windows UWP.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jul 4, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jul 4, 2026
@thexai
thexai force-pushed the uwp-posixmodule branch 2 times, most recently from 1a0e742 to a9bed96 Compare July 4, 2026 06:31
@cmaloney

cmaloney commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Please don't force push to CPython PR Branches.

The issue description here is a little confusing as this shows up as the module nt (posixmodule.c is exported as nt on windows and posix elsewhere). Would be better to have the NEWs refer to the module as that is what users of CPython see in their codebase:

:mod:`!nt`:

(The ! at the start is because there isn't a dedicated module page for nt currently in the docs although there probably should be).

For the windows specific pieces need review from @python/windows-team

thexai reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba zooba added the skip news label Jul 6, 2026
@zooba

zooba commented Jul 6, 2026

Copy link
Copy Markdown
Member

The change looks fine to me, and in line with my comments on the other PR we merged earlier today, let's just skip NEWS here (all that changes is that a failing custom build becomes a successful one).

thexai reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@thexai thexai mentioned this pull request Jul 6, 2026
gh-153091: Fix os.listvolumes() should be only available for MS_WINDOWS_DESKTOP #153095
Closed
@thexai
pythongh-152433: Windows: allow build posixmodule.c for Windows UWP
b797649
@thexai
thexai force-pushed the uwp-posixmodule branch from e5c23d9 to b797649 Compare July 6, 2026 17:05
@thexai

thexai commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

NEWS removed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Jul 6, 2026

Copy link
Copy Markdown
Member

I'm sure you'll be told again, but every time you force push a small change, we cannot verify your change. You force us to re-review the entire pull request again, because the incremental change you made is gone.

That annoys us and slows us down. You'll get fewer reviews and find it harder to get your changes merged.

Please just work with us here. We always squash merge, so intermediate commits won't show up anyway, and we usually rewrite commit messages to make sure the important information is included. The commit history within a PR is there to serve the reviewers, and force pushing is the best way to not serve the reviewers.

thexai reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@thexai

thexai commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

I understand, but I only removed NEWS and assumed it was the easiest way.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@thexai
Add additional required changes
2791915
@thexai thexai closed this Jul 14, 2026
@thexai thexai reopened this Jul 14, 2026
zooba
zooba reviewed Jul 14, 2026
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@thexai
Remove ShellExecute changes
2ba614a
@zooba
zooba merged commit ba28946 into python:main Jul 14, 2026
92 of 94 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Jul 14, 2026
@zooba

zooba commented Jul 14, 2026

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@thexai
thexai deleted the uwp-posixmodule branch July 15, 2026 15:43
thexai added a commit to thexai/cpython that referenced this pull request Jul 17, 2026
@thexai
pythongh-152433: Allow posixmodule.c to build for Windows UWP (python…
dd325fd
…GH-152998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@thexai @cmaloney @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.