GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (GH-100373) by miss-islington · Pull Request #153311 · python/cpython

Conversation

miss-islington commented Jul 8, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

In PEM, we need to parse until error and then suppress PEM_R_NO_START_LINE, because PEM allows arbitrary leading and trailing data. DER, however, does not. Parsing until error and suppressing ASN1_R_HEADER_TOO_LONG doesn't quite work because that error also covers some cases that should be rejected.

Instead, check BIO_eof early and stop the loop that way.
(cherry picked from commit acfe02f)

Co-authored-by: David Benjamin [email protected]
Automerge-Triggered-By: GH:Yhg1s

Issue: SSLContext.load_verify_locations accepts some cases of trailing data in DER #100372

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gamercoool697-arch reacted with thumbs up emoji

gamercoool697-arch reacted with rocket emoji

All reactions

👍 1 reaction
🚀 1 reaction


          pythongh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (pyt…

7eca7c5

…honGH-100373)

In PEM, we need to parse until error and then suppress `PEM_R_NO_START_LINE`, because PEM allows arbitrary leading and trailing data. DER, however, does not. Parsing until error and suppressing `ASN1_R_HEADER_TOO_LONG` doesn't quite work because that error also covers some cases that should be rejected.

Instead, check `BIO_eof` early and stop the loop that way.
(cherry picked from commit acfe02f)

Co-authored-by: David Benjamin <[email protected]>
Automerge-Triggered-By: GH:Yhg1s

This was referenced Jul 8, 2026

SSLContext.load_verify_locations accepts some cases of trailing data in DER #100372

Closed

gh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 #100373

Merged

bedevere-app Bot added the awaiting review label

Jul 8, 2026

read-the-docs-community Bot commented Jul 8, 2026

Copy link

Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33491520 | 📁 Comparing 7eca7c5 against main (aa533dc)

🔍 Preview build

565 files changed · + 18 added · ± 475 modified · - 72 deleted

+ Added

± Modified

- Deleted

gamercoool697-arch reacted with hooray emoji

gamercoool697-arch reacted with rocket emoji

All reactions

🎉 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou marked this pull request as draft

July 8, 2026 08:07

bedevere-app Bot removed the awaiting review label

Jul 8, 2026

vstinner approved these changes

Jul 11, 2026

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@encukou: Why did you mark the PR as a draft? IMO we should apply this fix to Python 3.11 (the macOS CI is failing).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gamercoool697-arch reacted with hooray emoji

gamercoool697-arch reacted with rocket emoji

All reactions

🎉 1 reaction
🚀 1 reaction

bedevere-app Bot added the awaiting merge label

Jul 11, 2026

This was referenced Jul 11, 2026

[3.11] gh-149776: Skip UDP Lite tests if it's not supported (#149777) #153593

Merged

3.10, 3.11, 3.12: Windows fails to build, test_ssl NOT_ENOUGH_DATA failure on macOS, test_socket fails on Fedora Stable (Linux 7.1) #153598

Open

encukou commented Jul 12, 2026

Copy link

Copy Markdown

Member

LGTM.

@encukou: Why did you mark the PR as a draft? IMO we should apply this fix to Python 3.11 (the macOS CI is failing).

See here: #100373 (comment)

It's not a security issue; if the RM doesn't want this fix we can also skip the test.

gamercoool697-arch reacted with hooray emoji

gamercoool697-arch reacted with rocket emoji

All reactions

🎉 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou mentioned this pull request

Aug 10, 2026

[3.10] gh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (GH-100373) #153312

Merged

encukou marked this pull request as ready for review

August 10, 2026 07:51

bedevere-app Bot removed the awaiting merge label

Aug 10, 2026


          Merge branch '3.11' into backport-acfe02f-3.11

7b24966

bedevere-app Bot added the awaiting review label

Aug 10, 2026

encukou commented Aug 10, 2026

Copy link

Copy Markdown

Member

Pablo wants the fix, so I moved them out of draft.

vstinner reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal merged commit 5f13018 into python:3.11

Aug 10, 2026

25 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

Aug 10, 2026

miss-islington deleted the backport-acfe02f-3.11 branch

August 10, 2026 17:09

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

miss-islington commented Jul 8, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

read-the-docs-community Bot commented Jul 8, 2026

Documentation build overview

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

encukou commented Jul 12, 2026

Uh oh!

encukou commented Aug 10, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miss-islington commented Jul 8, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.