GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (GH-100373) by miss-islington · Pull Request #153312 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 8, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In PEM, we need to parse until error and then suppress PEM_R_NO_START_LINE, because PEM allows arbitrary leading and trailing data. DER, however, does not. Parsing until error and suppressing ASN1_R_HEADER_TOO_LONG doesn't quite work because that error also covers some cases that should be rejected.

Instead, check BIO_eof early and stop the loop that way.
(cherry picked from commit acfe02f)

Co-authored-by: David Benjamin [email protected]
Automerge-Triggered-By: GH:Yhg1s

  • Issue: SSLContext.load_verify_locations accepts some cases of trailing data in DER #100372

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@davidben @miss-islington
pythongh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (pyt…
122e7da 
…honGH-100373)

In PEM, we need to parse until error and then suppress `PEM_R_NO_START_LINE`, because PEM allows arbitrary leading and trailing data. DER, however, does not. Parsing until error and suppressing `ASN1_R_HEADER_TOO_LONG` doesn't quite work because that error also covers some cases that should be rejected.

Instead, check `BIO_eof` early and stop the loop that way.
(cherry picked from commit acfe02f)

Co-authored-by: David Benjamin <[email protected]>
Automerge-Triggered-By: GH:Yhg1s
@miss-islington
miss-islington requested a review from tiran as a code owner July 8, 2026 07:55
@bedevere-app bedevere-app Bot mentioned this pull request Jul 8, 2026
SSLContext.load_verify_locations accepts some cases of trailing data in DER #100372
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 8, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 8, 2026
gh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 #100373
Merged
@encukou
encukou marked this pull request as draft July 8, 2026 08:07
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 8, 2026
vstinner
vstinner approved these changes Jul 11, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@encukou: Why did you mark the PR as a draft? IMO we should apply this fix to Python 3.10 (the macOS CI is failing).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Jul 11, 2026
This was referenced Jul 11, 2026
[3.10] gh-149776: Skip UDP Lite tests if it's not supported (#149777) #153594
Merged
3.10, 3.11, 3.12: Windows fails to build, test_ssl NOT_ENOUGH_DATA failure on macOS, test_socket fails on Fedora Stable (Linux 7.1) #153598
Open
@hugovk
Merge branch '3.10' into backport-acfe02f-3.10
b7e4d49
@hugovk hugovk mentioned this pull request Aug 10, 2026
[3.10] gh-90949: expose Expat API to tune exponential expansion protections (GH-139368) (#151401) #155414
Merged
@encukou

encukou commented Aug 10, 2026

Copy link
Copy Markdown
Member

@encukou: Why did you mark the PR as a draft? IMO we should apply this fix to Python 3.10 (the macOS CI is failing).

Same reason as on the 3.11 one.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou marked this pull request as ready for review August 10, 2026 07:52
@bedevere-app bedevere-app Bot added awaiting review and removed awaiting merge labels Aug 10, 2026
@pablogsal
pablogsal merged commit 129667d into python:3.10 Aug 10, 2026
17 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 10, 2026
@miss-islington
miss-islington deleted the backport-acfe02f-3.10 branch August 10, 2026 17:09
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
@miss-islington @davidben
@hugovk @icanhasmath
[3.10] pythongh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_AS…
3eb4181 
…N1 (pythonGH-100373) (python#153312)

pythongh-100372: Use BIO_eof to detect EOF for SSL_FILETYPE_ASN1 (pythonGH-100373)

In PEM, we need to parse until error and then suppress `PEM_R_NO_START_LINE`, because PEM allows arbitrary leading and trailing data. DER, however, does not. Parsing until error and suppressing `ASN1_R_HEADER_TOO_LONG` doesn't quite work because that error also covers some cases that should be rejected.

Instead, check `BIO_eof` early and stop the loop that way.
(cherry picked from commit acfe02f)

Automerge-Triggered-By: GH:Yhg1s

Co-authored-by: David Benjamin <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit 129667d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @encukou @vstinner @pablogsal @davidben @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.