GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-143750: Compile OpenSSL with TSan for TSan CI by kumaraditya303 · Pull Request #153316 · python/cpython

Conversation

kumaraditya303 commented Jul 8, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This PR supersedes #143752 and builds openssl with tsan for tsan CI to avoid false-positives.

Issue: Use OpenSSL instrumented with TSan for TSan tests #143750

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot mentioned this pull request

Jul 8, 2026

Use OpenSSL instrumented with TSan for TSan tests #143750

Closed

kumaraditya303 added the skip news label

Jul 8, 2026

colesbury and others added 2 commits

July 8, 2026 15:37


          pythongh-143750: Compile OpenSSL with TSan for TSan CI

06b4de4

- Also fix "Install dependencies" step so that we use the installed Clang.
  We can use clang-20 on both ASan and TSan now.


          Revert "Temporarily allow the TSan (free-threading) job to fail (pyth…

c25b785

…on#152173)"

This reverts commit 4f39efc.

kumaraditya303 force-pushed the gh-143750-openssl-tsan branch from 8936cbc to c25b785 Compare

July 8, 2026 10:09


          make CI optional again for now

c89f2a4

kumaraditya303 mentioned this pull request

Jul 8, 2026

Data race in test_ssl.test_sni_callback_race #150191

Closed

kumaraditya303 marked this pull request as ready for review

July 8, 2026 11:13

kumaraditya303 requested review from AA-Turner, JacobCoffee, ezio-melotti, gpshead, hugovk, itamaro, picnixz and webknjaz as code owners

July 8, 2026 11:13

bedevere-app Bot added the awaiting core review label

Jul 8, 2026


          Merge branch 'main' into pythongh-143750-openssl-tsan

5591bbe

webknjaz reviewed

Jul 8, 2026

View reviewed changes

webknjaz left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, seems good, but I have a few cosmetic notes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.


          address review

bc62a6a

webknjaz reviewed

Jul 8, 2026

View reviewed changes

Comment thread

.github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

webknjaz approved these changes

Jul 8, 2026

View reviewed changes

webknjaz left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kumaraditya303 merged commit fc19ad7 into python:main

Jul 8, 2026

48 checks passed

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 deleted the gh-143750-openssl-tsan branch

July 8, 2026 15:15

bedevere-app Bot removed the awaiting core review label

Jul 8, 2026

kumaraditya303 added needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Jul 8, 2026

miss-islington-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned kumaraditya303

Jul 8, 2026

miss-islington-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.15

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

GH-153353 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Jul 8, 2026

bedevere-app Bot commented Jul 8, 2026

Copy link

Copy Markdown

GH-153355 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jul 8, 2026

kumaraditya303 added a commit that referenced this pull request

Jul 8, 2026


          [3.15] gh-143750: Compile OpenSSL with TSan for TSan CI (#153316) (#1…

6af15c9

…53353)

gh-143750: Compile OpenSSL with TSan for TSan CI (#153316)

(cherry picked from commit fc19ad7)

Co-authored-by: Sam Gross <[email protected]>

kumaraditya303 added a commit that referenced this pull request

Jul 10, 2026


          [3.14] gh-143750: Compile OpenSSL with TSan for TSan CI (#153316) (#1…

b49ec81

…53355)

Compile OpenSSL with TSan in the TSan CI job so that data races between
Python code and OpenSSL internals are visible to the sanitizer.

Also skip test_ssl_in_multiple_threads under TSan: concurrent calls to
SSLContext.load_cert_chain on the same context race on the SSL_CTX
default password callback. The race is fixed in 3.15+ (GH-143818), but
with TSan-instrumented OpenSSL it is now reported on 3.14.

(cherry picked from commit fc19ad7)

Co-authored-by: Sam Gross <[email protected]>

StanFromIreland mentioned this pull request

Sep 4, 2026

gh-143750: Compile OpenSSL with TSan for TSan CI #143752

Closed

Reviewers

webknjaz

webknjaz approved these changes

gpshead

Awaiting requested review from gpshead

gpshead is a code owner

picnixz

Awaiting requested review from picnixz

picnixz is a code owner

ezio-melotti

Awaiting requested review from ezio-melotti

ezio-melotti is a code owner

hugovk

Awaiting requested review from hugovk

hugovk is a code owner

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

itamaro

Awaiting requested review from itamaro

itamaro is a code owner

JacobCoffee

Awaiting requested review from JacobCoffee

JacobCoffee is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kumaraditya303 commented Jul 8, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webknjaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webknjaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Jul 8, 2026

Uh oh!

miss-islington-app Bot commented Jul 8, 2026

Uh oh!

miss-islington-app Bot commented Jul 8, 2026

Uh oh!

miss-islington-app Bot commented Jul 8, 2026

Uh oh!

bedevere-app Bot commented Jul 8, 2026

Uh oh!

bedevere-app Bot commented Jul 8, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kumaraditya303 commented Jul 8, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.