GeezerVison

Copy link

Copy Markdown

Contributor

harjothkhara requested review from FFY00, brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners July 16, 2026 05:16

brettcannon removed their request for review July 17, 2026 19:12

itamaro requested changes Oct 3, 2026

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

itamaro reviewed Oct 10, 2026

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot requested a review from itamaro October 10, 2026 17:39

itamaro approved these changes Oct 10, 2026

View reviewed changes

55 of 56 checks passed

…thon#153799)

`zipimporter.get_filename()` compiled source modules just to work out the
module's file name. `find_spec()` calls it through `spec_from_loader()`, so
importing a source module from a ZIP archive compiled it twice and emitted
every `SyntaxWarning` twice.

`get_filename()` now returns before reading or compiling the source.
As a result, a `SyntaxError` in a zipped source module is now raised by
`exec_module()` rather than by `find_spec()` or `get_filename()`, and
the source isn't compiled twice during import, which matches
the filesystem-based loaders.

cherry_picker 230917f5072c5c6b9373374a84d52935d7afa3b5 3.14

…H-153799) (#159729)

gh-141276: Avoid compiling zipimport source in get_filename (GH-153799)

`zipimporter.get_filename()` compiled source modules just to work out the
module's file name. `find_spec()` calls it through `spec_from_loader()`, so
importing a source module from a ZIP archive compiled it twice and emitted
every `SyntaxWarning` twice.

`get_filename()` now returns before reading or compiling the source.
As a result, a `SyntaxError` in a zipped source module is now raised by
`exec_module()` rather than by `find_spec()` or `get_filename()`, and
the source isn't compiled twice during import, which matches
the filesystem-based loaders.
(cherry picked from commit 230917f)

Co-authored-by: Harjoth Khara <[email protected]>

pythonGH-153799 landed without a few of the review suggestions:

- a versionchanged note on get_filename() in the docs;
- a What's New entry describing both the SyntaxWarning fix and the
  behavior change;
- tests for a stale .pyc next to a .py with a syntax error (falls
  through to the .py, and the SyntaxError is deferred to exec_module()),
  and for get_filename()/find_spec() not reading the source at all.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Kq5LwfysHx5inm3J1TQCdS

…H-153799) (#161504)

`zipimporter.get_filename()` compiled source modules just to work out the
module's file name. `find_spec()` calls it through `spec_from_loader()`, so
importing a source module from a ZIP archive compiled it twice and emitted
every `SyntaxWarning` twice.

`get_filename()` now returns before reading or compiling the source.
As a result, a `SyntaxError` in a zipped source module is now raised by
`exec_module()` rather than by `find_spec()` or `get_filename()`, and
the source isn't compiled twice during import, which matches
the filesystem-based loaders.

(cherry picked from commit 230917f)

Co-authored-by: Harjoth Khara <[email protected]>