GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-153896: Deduplicate mutable args in `Literal` type by sobolevn · Pull Request #153913 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It does not look to complex as a change, moreover this brings consistency among different arg types. Desipe the fact that Literal[[], []] does not really make much sense as a typing form as of right now.

But, it might be for some custom runtime type checks / etc.

Should we backport this?

  • Issue: Literal[...] deduplication silently skips when values are unhashable #153896

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
pythongh-153896: Deduplicate mutable args in Literal type
3a7402c
@sobolevn
sobolevn requested review from AlexWaygood and JelleZijlstra as code owners July 18, 2026 10:35
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
Literal[...] deduplication silently skips when values are unhashable #153896
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2026
@picnixz picnixz mentioned this pull request Jul 18, 2026
gh-153896: Deduplicate unhashable Literal params #153914
Merged
@Maxinho96

Maxinho96 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@sobolenv I am at the Europython sprints and I was already preparing the PR to fix the issue, but you were faster 😢 my fix looks very similar to yours, would you be so kind to let me merge my first contribution to CPython? 🙏🏻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @Maxinho96
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.