GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — gh-153896: Deduplicate unhashable Literal params by Maxinho96 · Pull Request #153914 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
python-cla-bot
Bot
commented
Jul 18, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
All commit authors signed the Contributor License Agreement. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Member
|
Sure, since this is the first contribution by @Maxinho96, I would prefer to merge their PR :) |
All reactions
-
👍 1 reaction -
❤️ 2 reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Jul 18, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Member
Oh no, closing! 😱 I am joking, obviously (not about the Roma part) :) |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
reviewed
Jul 18, 2026
Comment on lines
+778
to
780
| value_and_type_parameters = list(_value_and_type_iter(parameters)) | ||
| deduplicated_parameters = tuple(p for p, _ in _deduplicate(value_and_type_parameters, unhashable_fallback=True)) | ||
|
|
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ususally want lines under 80 charactesr, so I suggest that you rename value_and_type_parameters to a shorter name or you use the same format as Nikita:
parameters = tuple( p for p, _ in _deduplicate( list(_value_and_type_iter(parameters)), unhashable_fallback=True, ) )
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future: how do I enforce the correct formatting? The pre-commit hook passed for some reason. I see it uses ruff, but if I run it one the codebase it changes all the files
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this is a manual task =/ we do have some parts of the stdlib with ruff configs, but for historical reasons, we don't enforce style on old files (for maintenance and diff purposes) and only try to enforce them for new code (so code you add, or code you change around). See PEP-7/PEP-8 guidelines (while they are guidelines, sometimes we need to break them because it's not consistent).
What we aim for:
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
-
👍 1 reaction
Member
|
@Maxinho96 Make sure to add a NEWS entry as well :) |
All reactions
-
👍 1 reaction -
👀 1 reaction
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
reviewed
Jul 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
@sobolevn lol what are the chances? I forgive you for your sins since you kindly let me contribute, thanks! 🙏🏻 |
All reactions
-
😄 2 reactions -
❤️ 1 reaction
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ZeroIntensity
approved these changes
Jul 18, 2026
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me.
I think backporting makes sense here. It's unlikely that people are relying on this in a way that would break code; if anything, people could have been running their own deduplication pass on __args__, but that won't be broken by this fix.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 16, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 16, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 16, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 17, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 18, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 18, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 20, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 21, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 23, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 23, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 24, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 24, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 26, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 26, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 28, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 29, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 29, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 29, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Aug 30, 2026
…l dedup test_literal_values_unhashable_type asserts that duplicate unhashable Literal values (e.g. Literal[[1, 'a'], [1, 'a']]) are preserved, but CPython 3.13.15+ deduplicates unhashable Literal args at construction time (python/cpython#153914). Upstream fixed this the same way starting in 0.4.4 by skipping the test on newer Python; backport that same guard here since this recipe is pinned to 0.4.2. AI-Generated: Uses Claude Code Signed-off-by: Khem Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.