GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-71896: warn in doc about trailing newlines ignored by HtmlDiff by Lenormju · Pull Request #153930 · python/cpython

Conversation

@Lenormju

@Lenormju Lenormju commented Jul 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: difflib.HtmlDiff produces different output from difflib.ndiff #71896

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Lenormju
docs: warn about trailing newlines ignored by HtmlDiff
dacd1f3
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
difflib.HtmlDiff produces different output from difflib.ndiff #71896
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 18, 2026
@chris-eibl chris-eibl added the sprint label Jul 18, 2026
@github-project-automation github-project-automation Bot added this to Sprint Jul 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@chris-eibl
chris-eibl requested a review from encukou July 18, 2026 11:54
@read-the-docs-community

read-the-docs-community Bot commented Jul 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33646212 | 📁 Comparing 368fd1e against main (bc2fd44)

  🔍 Preview build  

9 files changed · ± 9 modified

± Modified

  • library/allos.html
  • library/calendar.html
  • library/ctypes.html
  • library/difflib.html
  • library/functions.html
  • library/inspect.html
  • whatsnew/3.15.html
  • whatsnew/3.16.html
  • whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lenormju
add missing NEWS item
c69757e
@Lenormju

Lenormju commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

I have added a NEWS item after discussing with Chris, because it is not only a documentation change but also a new test and a comment in the actual Lib code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Jul 18, 2026

Copy link
Copy Markdown
Member

I don't think this needs a news entry as there's no behavior change here. We don't add changelog entries for new tests, so let's remove the blurb here. I discussed this with Chris as well, and he agrees.
chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lenormju
remove actually unwanted NEWS
368fd1e
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lenormju

Lenormju commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity I removed it
ZeroIntensity reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 18, 2026
ZeroIntensity
ZeroIntensity approved these changes Jul 18, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 18, 2026
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 18, 2026
@ZeroIntensity
ZeroIntensity enabled auto-merge (squash) July 18, 2026 13:21
@ZeroIntensity
ZeroIntensity merged commit 755d971 into python:main Jul 18, 2026
66 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Thanks @Lenormju for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
Lenormju reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153965 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Sorry, @Lenormju and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 755d97167f6f5d4361c790f8f18df76cae8f2ad2 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ZeroIntensity Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153966 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153968 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 18, 2026
ZeroIntensity pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @Lenormju
[3.15] gh-71896: Add a docs warning about trailing newlines ignored b…
b6a140b 
…y `difflib.HtmlDiff` (GH-153930) (GH-153965)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <[email protected]>
ZeroIntensity added a commit that referenced this pull request Jul 18, 2026
@ZeroIntensity @Lenormju
[3.13] gh-71896: Add a docs warning about trailing newlines ignored b…
75b6789 
…y `difflib.HtmlDiff` (GH-153930) (GH-153968)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <[email protected]>
ZeroIntensity pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @Lenormju
[3.14] gh-71896: Add a docs warning about trailing newlines ignored b…
1f3814f 
…y `difflib.HtmlDiff` (GH-153930) (GH-153966)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <[email protected]>
@Lenormju
Lenormju deleted the gh-71896-warn-about-bug-in-htmldiff branch July 18, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ZeroIntensity ZeroIntensity

Labels

skip news sprint

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Lenormju @ZeroIntensity @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.