GeezerVison is showing github.com — gh-154053: Fix compilation of the ssl module against LibreSSL by serhiy-storchaka · Pull Request #154054 · python/cpython
Conversation
serhiy-storchaka
commented
Jul 19, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Since gh-138252 (TLS signature-algorithm support, 3.15+), _ssl fails to compile against LibreSSL, which does not provide SSL_CTX_set1_sigalgs_list() / SSL_CTX_set1_client_sigalgs_list():
Modules/_ssl.c:3867: call to undeclared function 'SSL_CTX_set1_client_sigalgs_list'
Modules/_ssl.c:3887: call to undeclared function 'SSL_CTX_set1_sigalgs_list'
With -Werror=implicit-function-declaration this is fatal, so _ssl is not built at all on LibreSSL (regression from 3.14).
This PR guards the set_client_sigalgs/set_server_sigalgs methods so they raise NotImplementedError on LibreSSL (matching how other library-unavailable features are handled in _ssl.c), and skips the corresponding test_ssl tests.
Verified:
- OpenSSL 3.5.5: builds clean, sigalgs tests pass (unaffected).
- LibreSSL 4.3.0 (OpenBSD 7.9):
_ssl now compiles; the 7 sigalgs tests skip; the remaining test_ssl failures are identical to those already present on 3.14 (pre-existing LibreSSL divergences), i.e. no new failures.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
LibreSSL does not provide SSL_CTX_set1_sigalgs_list() or
SSL_CTX_set1_client_sigalgs_list(), added in pythongh-138252, so _ssl failed to
compile against LibreSSL on 3.15+. Guard the set_server_sigalgs() and
set_client_sigalgs() methods so they raise NotImplementedError on LibreSSL,
and skip the corresponding tests.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 19, 2026
…H-154054) (GH-154075)
LibreSSL does not provide SSL_CTX_set1_sigalgs_list() or
SSL_CTX_set1_client_sigalgs_list(), added in gh-138252, so _ssl failed to
compile against LibreSSL on 3.15+. Guard the set_server_sigalgs() and
set_client_sigalgs() methods so they raise NotImplementedError on LibreSSL,
and skip the corresponding tests.
(cherry picked from commit 39b058f)
Co-authored-by: Serhiy Storchaka <[email protected]>
Reviewers
gpshead
Awaiting requested review from gpshead
gpshead is a code owner
picnixz
Awaiting requested review from picnixz
picnixz is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|