GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154189: Fix use-after-free in `functools.partial_vectorcall` by brijkapadia · Pull Request #154508 · python/cpython

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Jul 22, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: use-after-free: functools partial #154189

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brijkapadia
pythongh-154189: Fix use-after-free in functools.partial_vectorcall
082e340
@brijkapadia
brijkapadia requested a review from rhettinger as a code owner July 22, 2026 19:59
@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2026
use-after-free: functools partial #154189
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 22, 2026
@brijkapadia

brijkapadia commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@encukou, could you review this whenever you have time?
I'm asking since you reviewed #145362, which is similar to this pr.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Jul 24, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This checks out. Are you up for a bit of additional cleanup?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brijkapadia reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 24, 2026
@brijkapadia
cleanup
dc25bc0
encukou
encukou approved these changes Jul 24, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou encukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 24, 2026
@encukou
encukou merged commit 1a742d4 into python:main Jul 24, 2026
62 of 63 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 24, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @brijkapadia for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Sorry, @brijkapadia and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a742d403243ac9915ffcc54e29516e58c44dc42 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou Jul 24, 2026
@bedevere-app

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154652 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 24, 2026
@brijkapadia
brijkapadia deleted the partial-vectorcall branch July 24, 2026 21:42
@brijkapadia

brijkapadia commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

I don't think PR needs to be backported to 3.14.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou pushed a commit that referenced this pull request Jul 27, 2026
@miss-islington @brijkapadia
[3.15] gh-154189: Fix use-after-free in functools.partial_vectorcall (
6246342 
GH-154508) (#154652)

(cherry picked from commit 1a742d4)

Co-authored-by: Brij Kapadia <[email protected]>
@encukou

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member

I agree; it doesn't look worth the effort.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou removed the needs backport to 3.14 bugs and security fixes label Jul 27, 2026
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@brijkapadia @mbeijen
pythongh-154189: Fix use-after-free in functools.partial_vectorcall (…
231b8c6 
…pythonGH-154508)
@mattsta mattsta mentioned this pull request Oct 10, 2026
Free-threaded 3.15: a functools.partial shared between threads no longer scales (it slows down as you add threads) #159157
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brijkapadia @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.