GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93251: Decode localized socket error messages from the locale encoding by serhiy-storchaka · Pull Request #154683 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so gaierror and herror could be replaced with UnicodeDecodeError if the message is localized and the locale encoding is not UTF-8. Decode them from the locale encoding with the "surrogateescape" error handler.

Reproduced with the Ukrainian KOI8-U locale on Linux and the Japanese EUC-JP locale on FreeBSD (where it also made test_logging fail). The new test runs under a number of locales with non-ASCII localized messages, at least one of which is available on each of Linux, FreeBSD, NetBSD, DragonFly BSD, OpenIndiana and macOS.

  • Issue: socket.getfqdn() UnicodeDecodeError depending on LANG variable #93251

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @claude
pythongh-93251: Decode localized socket error messages from the local…
6304ae8 
…e encoding

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so
gaierror and herror could be replaced with UnicodeDecodeError if the
message is localized and the locale encoding is not UTF-8.

Co-Authored-By: Claude Fable 5 <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2026
socket.getfqdn() UnicodeDecodeError depending on LANG variable #93251
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 25, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 25, 2026
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 26, 2026
gh-154682: Fix corruption of locale-encoded text on FreeBSD, NetBSD, DragonFly BSD and macOS #154722
Draft
@serhiy-storchaka
serhiy-storchaka merged commit 5afbb60 into python:main Jul 26, 2026
103 of 106 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 26, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 26, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the gh-93251-gaierror branch July 26, 2026 09:31
@bedevere-app

bedevere-app Bot commented Jul 26, 2026

Copy link
Copy Markdown

GH-154723 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 26, 2026
@bedevere-app

bedevere-app Bot commented Jul 26, 2026

Copy link
Copy Markdown

GH-154724 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 26, 2026
@bedevere-app

bedevere-app Bot commented Jul 26, 2026

Copy link
Copy Markdown

GH-154725 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 26, 2026
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2026
@miss-islington @serhiy-storchaka @claude
[3.14] gh-93251: Decode localized socket error messages from the loca…
b9723f9 
…le encoding (GH-154683) (GH-154724)

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so
gaierror and herror could be replaced with UnicodeDecodeError if the
message is localized and the locale encoding is not UTF-8.
(cherry picked from commit 5afbb60)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2026
@miss-islington @serhiy-storchaka @claude
[3.15] gh-93251: Decode localized socket error messages from the loca…
6e6884b 
…le encoding (GH-154683) (GH-154723)

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so
gaierror and herror could be replaced with UnicodeDecodeError if the
message is localized and the locale encoding is not UTF-8.
(cherry picked from commit 5afbb60)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2026
@miss-islington @serhiy-storchaka @claude
[3.13] gh-93251: Decode localized socket error messages from the loca…
501e911 
…le encoding (GH-154683) (GH-154725)

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so
gaierror and herror could be replaced with UnicodeDecodeError if the
message is localized and the locale encoding is not UTF-8.
(cherry picked from commit 5afbb60)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@serhiy-storchaka @claude @mbeijen
pythongh-93251: Decode localized socket error messages from the local…
4fc5c05 
…e encoding (pythonGH-154683)

The gai_strerror() and hstrerror() messages were decoded as UTF-8, so
gaierror and herror could be replaced with UnicodeDecodeError if the
message is localized and the locale encoding is not UTF-8.

Co-authored-by: Claude Fable 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.