GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154431: Revert "gh-154431: Fix data race in `sys.audithook` (#154462)" by encukou · Pull Request #154769 · python/cpython

Conversation

@encukou

@encukou encukou commented Jul 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 596cd5c.

This commit caused a refleak, breaking a tier 1 buildbot.

  • Issue: Data race: sys.addaudithook() lazily creates interp->audit_hooks with no lock #154431

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Revert "pythongh-154431: Fix data race in sys.audithook (python#154462
c96bdde 
)"

This commit caused a refleak.

This reverts commit 596cd5c.
@encukou
encukou requested review from FFY00, ZeroIntensity and ericsnowcurrently as code owners July 27, 2026 12:25
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 27, 2026
Data race: sys.addaudithook() lazily creates interp->audit_hooks with no lock #154431
Open
@encukou

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

The reverted commit caused a refleak, breaking a tier 1 buildbot; see e.g. https://buildbot.python.org/#/builders/1610/builds/3726
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

!buildbot CentOS9.NoGIL.Refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 27, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit c96bdde 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F154769%2Fmerge

The command will test the builders whose names match following regular expression: CentOS9.NoGIL.Refleaks

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 27, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed ✅ https://buildbot.python.org/all/#/builders/1606/builds/935

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 27, 2026
@encukou
encukou merged commit c7b9a13 into python:main Jul 27, 2026
103 of 105 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 27, 2026
@encukou
encukou deleted the revert-596cd5c branch July 27, 2026 14:00
@encukou encukou added the needs backport to 3.15 bugs and security fixes label Jul 27, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 27, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jul 27, 2026

Copy link
Copy Markdown

GH-154774 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 27, 2026
encukou added a commit that referenced this pull request Jul 27, 2026
@miss-islington @encukou
[3.15] gh-154431: Revert "gh-154431: Fix data race in sys.audithook (…
44fca7e 
…GH-154462)" (GH-154769) (GH-154774)

This reverts commit 596cd5c.
This commit caused a refleak.

(cherry picked from commit c7b9a13)

Co-authored-by: Petr Viktorin <[email protected]>
@0rkz 0rkz mentioned this pull request Jul 28, 2026
Correctness/dispute layer as the missing piece downstream of settlement x402-foundation/x402#2887
Open
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@encukou @mbeijen
pythongh-154431: Revert "pythongh-154431: Fix data race in `sys.audit…
a3b278f 
…hook` (python#154462)" (pythonGH-154769)

This commit caused a refleak.

This reverts commit 596cd5c.
@ngoldbaum ngoldbaum mentioned this pull request Oct 30, 2026
Audit all built-in modules for thread safety #116738
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.