GeezerVison is showing github.com — gh-98894: fix `CheckDtraceProbes` tests on Solaris by kulikjak · Pull Request #154803 · python/cpython
Conversation
kulikjak
commented
Jul 28, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Solaris does not use the notes section to list available probes (readelf -n <binary> returns nothing), which makes the test_check_probes fail.
This PR adds a Solaris specific path which gets all the available probes by listing those available in the running test process instead.
The output below is very different so the comparison needs to be updated a little as well.
>>> import subprocess
>>> import os
>>> res = subprocess.run(["dtrace", "-l", "-P", f"python{os.getpid()}"])
ID PROVIDER MODULE FUNCTION NAME
34 python1427 libpython3.16.so.1.0 sys_audit audit
35 python1427 libpython3.16.so.1.0 sys_audit_tstate.part.0 audit
36 python1427 libpython3.16.so.1.0 dtrace_function_entry function-entry
37 python1427 libpython3.16.so.1.0 _PyEval_EvalFrameDefault function-entry
38 python1427 libpython3.16.so.1.0 dtrace_function_return function-return
39 python1427 libpython3.16.so.1.0 _PyEval_EvalFrameDefault function-return
40 python1427 libpython3.16.so.1.0 gc_collect_main gc-done
41 python1427 libpython3.16.so.1.0 gc_collect_main gc-start
42 python1427 libpython3.16.so.1.0 import_find_and_load_with_name.isra.0 import-find-load-done
43 python1427 libpython3.16.so.1.0 import_find_and_load_with_name.isra.0 import-find-load-start
A little unfortunate thing is that the test now requires elevated privileges, but that is true of all other DTrace tests as well, so I don't think that's a big deal.
BTW: there is Solaris specific ELF section for DTrace metadata and at first I wanted to fix the test by reading that one (with readelf -p .SUNW_dof <binary>). Unfortunately, the section includes more metadata than just available probes, and the now removed line probe is also present in the dumped strings (so test_check_probes passes, but test_missing_probes unexpectedly passes as well).
It's possible to use elfdump and do some binary parsing to extract only the available ones, but that is a huge overkill for a test like this. For those interested, the change is here: kulikjak@564e946
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I didn't test the change on Solaris, but I trust @kulikjak for that.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@kulikjak: I pushed a merge commit to your branch to solve a merge conflict.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @kulikjak for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @kulikjak and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport manually with cherry_picker, see the devguide for more information.
cherry_picker 967fb3afc7e2f706d757925e9346f0bc8aab3c46 3.14
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Oct 17, 2026
Fix 'CheckDtraceProbes' tests by reading available probes from the test process itself.
Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit 967fb3a)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Merged! Thanks for your fix.
|
kulikjak reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
vstinner
vstinner approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|