GeezerVison is showing github.com — gh-127172: Honor umask and default ACL when installing venv activation scripts by tonghuaroot · Pull Request #154850 · python/cpython
Conversation
tonghuaroot
commented
Jul 29, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
venv installs the activation scripts (activate, activate.csh,
activate.fish) by copying the packaged template's mode onto the output, so
they always end up 0644 regardless of the process umask or any default ACL on
the target directory. Every other file venv creates (the pip wrappers, and
any file written afterwards) honors the umask and ACL, so the activation scripts
are the odd ones out: on a directory with a group-writable default ACL they come
out rw-r--r-- while pip* come out rw-rw-rw-.
Activation scripts are sourced, not executed, so they need no special mode. This
drops the mode-copying in install_scripts so the scripts inherit the umask and
default ACL like everything else venv writes.
The added regression test drives the process umask, so it needs no ACL support
and runs on every POSIX platform.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ivation scripts
venv wrote the activation scripts with a fixed mode copied from the packaged
templates, so they ignored the process umask and any default ACL, unlike every
other file venv creates. Copy only the data and let the new files inherit the
umask and ACL.
|
This PR is stale because it has been open for 90 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @tonghuaroot for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @tonghuaroot for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
vsajip
Awaiting requested review from vsajip
vsajip is a code owner
FFY00
Awaiting requested review from FFY00
FFY00 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
stale
Stale PR or inactive for long period of time.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|