GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127172: Honor umask and default ACL when installing venv activation scripts by tonghuaroot · Pull Request #154850 · python/cpython

Conversation

@tonghuaroot

@tonghuaroot tonghuaroot commented Jul 29, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

venv installs the activation scripts (activate, activate.csh,
activate.fish) by copying the packaged template's mode onto the output, so
they always end up 0644 regardless of the process umask or any default ACL on
the target directory. Every other file venv creates (the pip wrappers, and
any file written afterwards) honors the umask and ACL, so the activation scripts
are the odd ones out: on a directory with a group-writable default ACL they come
out rw-r--r-- while pip* come out rw-rw-rw-.

Activation scripts are sourced, not executed, so they need no special mode. This
drops the mode-copying in install_scripts so the scripts inherit the umask and
default ACL like everything else venv writes.

The added regression test drives the process umask, so it needs no ACL support
and runs on every POSIX platform.

  • Issue: venv module not respecting ACLs #127172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tonghuaroot
pythongh-127172: Honor umask and default ACL when installing venv act…
2303b0a
…ivation scripts

venv wrote the activation scripts with a fixed mode copied from the packaged
templates, so they ignored the process umask and any default ACL, unlike every
other file venv creates. Copy only the data and let the new files inherit the
umask and ACL.
@tonghuaroot
tonghuaroot requested review from FFY00 and vsajip as code owners July 29, 2026 04:22
@bedevere-app bedevere-app Bot mentioned this pull request Jul 29, 2026
venv module not respecting ACLs #127172
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jul 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 29, 2026
@vsajip
vsajip merged commit 1086205 into python:main Nov 12, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Nov 12, 2026
@vsajip vsajip added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 12, 2026
@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161855 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2026
@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161856 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tonghuaroot @vsajip
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.