GeezerVison is showing github.com — [3.14] gh-127172: Honor umask and default ACL when installing venv activation scripts (GH-154850) by miss-islington · Pull Request #161855 · python/cpython
Conversation
miss-islington
commented
Nov 12, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
venv wrote the activation scripts with a fixed mode copied from the packaged
templates, so they ignored the process umask and any default ACL, unlike every
other file venv creates. Copy only the data and let the new files inherit the
umask and ACL.
(cherry picked from commit 1086205)
Co-authored-by: tonghuaroot (童话) [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ivation scripts (pythonGH-154850)
venv wrote the activation scripts with a fixed mode copied from the packaged
templates, so they ignored the process umask and any default ACL, unlike every
other file venv creates. Copy only the data and let the new files inherit the
umask and ACL.
(cherry picked from commit 10862056f51eed3a332be3eefd51d4d6e871dade)
Co-authored-by: tonghuaroot (童话) <[email protected]>
This was referenced Nov 12, 2026
Reviewers
vsajip
Awaiting requested review from vsajip
vsajip is a code owner
FFY00
Awaiting requested review from FFY00
FFY00 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.