GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37947: Adjust correctly the recursion level in symtable for named expressions by pablogsal · Pull Request #15499 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 26, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue37947

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 26, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Aug 26, 2019
@pablogsal pablogsal added 🤖 automerge and removed 🤖 automerge labels Aug 26, 2019
@pablogsal
pablogsal requested a review from ncoghlan August 26, 2019 14:32
@pablogsal

pablogsal commented Aug 26, 2019

Copy link
Copy Markdown
Member Author

This is a fix also part of https://bugs.python.org/issue37954.

I will merge it to fix the reference leak for unblocking the upcoming beta release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
bpo-37947: Adjust correctly the recursion level in symtable for named…
9132f93 
… expressions
@pablogsal pablogsal added the needs backport to 3.8 label Aug 26, 2019
@pablogsal
pablogsal force-pushed the bpo37947 branch from 0169be2 to 9132f93 Compare August 26, 2019 14:34
@pablogsal
pablogsal merged commit 0e4ea16 into python:master Aug 26, 2019
@pablogsal
pablogsal deleted the bpo37947 branch August 26, 2019 14:52
@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 26, 2019
@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added needs backport to 3.8 and removed needs backport to 3.8 labels Aug 26, 2019
@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4ea16336685cf3fa353d8c54af59b45b2d5c33 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned pablogsal Aug 26, 2019
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Aug 26, 2019
@bedevere-bot

bedevere-bot commented Aug 26, 2019

Copy link
Copy Markdown

GH-15515 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 26, 2019
@pablogsal
[3.8] bpo-37947: Adjust correctly the recursion level in symtable for…
1d01f4e 
… named expressions (pythonGH-15499)

(cherry picked from commit 0e4ea16)

Co-authored-by: Pablo Galindo <[email protected]>
pablogsal added a commit that referenced this pull request Aug 26, 2019
@pablogsal
[3.8] bpo-37947: Adjust correctly the recursion level in symtable for…
3769425 
… named expressions (GH-15499) (GH-15515)

(cherry picked from commit 0e4ea16)

Co-authored-by: Pablo Galindo <[email protected]>
ncoghlan
ncoghlan reviewed Aug 29, 2019
View reviewed changes
Comment thread Python/symtable.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-37947: Adjust correctly the recursion level in symtable for named…
f09c2a4 
… expressions (pythonGH-15499)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37947: Adjust correctly the recursion level in symtable for named…
a17ec91 
… expressions (pythonGH-15499)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@pablogsal @websurfer5
bpo-37947: Adjust correctly the recursion level in symtable for named…
4a3e647 
… expressions (pythonGH-15499)
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
symtable_handle_namedexpr does not adjust correctly the recursion level #82128
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @miss-islington @bedevere-bot @ncoghlan @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.