GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-98820: Fix quadratic time in csv.Sniffer for quoted fields (GH-154867) by serhiy-storchaka · Pull Request #155166 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 4, 2026

Copy link
Copy Markdown
Member

Manual backport of #154867 to the security branch, cherry-picked from the 3.13 backport (commit b30c7fa).

The only conflict was in Lib/csv.py: 3.12 does not have gh-103925, so its patterns end with (?:$|\n) where the 3.13 pre-image had (?:$|\r|\n). After the resolution _guess_quote_and_delimiter() is identical to the 3.13 one.

Sniffing '"abcdefghijklmnopqrstuvwxyz"\n' * n with delimiters=',:|\t' takes 0.248, 0.977, 3.891 and 15.316 s for n = 1250, 2500, 5000 and 10000 before the change, and 0.026, 0.055, 0.109 and 0.216 s after it.

  • Issue: csv.Sniffer().sniff() Hangs on Single-Column Data #98820

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@miss-islington @serhiy-storchaka
[3.12] pythongh-98820: Fix quadratic time in csv.Sniffer for quoted f…
39dac55
…ields (pythonGH-154867)

(cherry picked from commit b30c7fa)
@bedevere-app bedevere-app Bot mentioned this pull request Aug 4, 2026
csv.Sniffer().sniff() Hangs on Single-Column Data #98820
Closed
@bedevere-app bedevere-app Bot added the type-security A security issue label Aug 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 4, 2026
[3.15] gh-98820: Fix quadratic time in csv.Sniffer for quoted fields #154867
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 4, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 needs backport to 3.11 only security fixes labels Aug 4, 2026
This was referenced Aug 4, 2026
[3.11] gh-109638: Fix exponential time in csv.Sniffer for doubled quotes (GH-154868) (GH-155113) #155115
Merged
[3.10] gh-109638: Fix exponential time in csv.Sniffer for doubled quotes (GH-154868) (GH-155113) #155116
Merged
@Yhg1s
Yhg1s merged commit 063d455 into python:3.12 Aug 4, 2026
31 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 4, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka and @Yhg1s, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 063d4555c94ef412c731527dbf30193327f2ee82 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned Yhg1s Aug 4, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka and @Yhg1s, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 063d4555c94ef412c731527dbf30193327f2ee82 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka deleted the backport-3.12-gh98820 branch August 4, 2026 19:03
@serhiy-storchaka

serhiy-storchaka commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Backports should be made after merging #155115 and #155116. Backport to 3.10 may be non-trivial, because possessive qualifiers are only supported since 3.11.

BHUVANSH855 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Aug 11, 2026
[3.11] gh-98820: Fix quadratic time in csv.Sniffer for quoted fields (GH-154867) #155538
Merged
[3.10] gh-98820: Fix quadratic time in csv.Sniffer for quoted fields (GH-154867) #155539
Merged
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @Yhg1s @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.