GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — [3.10] gh-98820: Fix quadratic time in csv.Sniffer for quoted fields (GH-154867) by serhiy-storchaka · Pull Request #155539 · python/cpython Conversation
Member
Manual backport of #154867, cherry-picked from the 3.12 backport (#155166), with one 3.10-only change in the second commit. Possessive quantifiers were added in 3.11, so other = r'(?:(?!(?P=quote)).)*' body = r'%s(?:(?P=quote){2}%s)*' % (other, other) Every position matches only one of the two alternatives, and each iteration of the outer loop consumes the two quote characters, so it does not backtrack. Checked against the 3.11 version of the file: no difference in the sniffed dialect on 90000 samples, and the same timings — sniffing
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…ields (pythonGH-154867) (cherry picked from commit b30c7fa) (cherry picked from commit 39dac55) They were added in 3.11. An unrolled loop is unambiguous at every position, so it does not backtrack either. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Uh oh!
There was an error while loading. Please reload this page.
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
…ields (pythonGH-154867) (python#155539) (cherry picked from commit fd78b56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
type-security
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |