GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-155278: Avoid needlessly accessing `ForwardRef.__forward_code__` in `evaluate_forward_ref()` by Viicos · Pull Request #155279 · python/cpython

Conversation

@Viicos

@Viicos Viicos commented Aug 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See issue for details. No news entry necessary for this kind of change.

  • Issue: Avoid needlessly accessing ForwardRef.__forward_code__ in evaluate_forward_ref() #155278

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Viicos
pythongh-155278: Avoid needlessly accessing `ForwardRef.__forward_cod…
24e985d 
…e__` in `evaluate_forward_ref()`
@Viicos
Viicos requested review from AlexWaygood and JelleZijlstra as code owners August 6, 2026 13:39
@bedevere-app bedevere-app Bot mentioned this pull request Aug 6, 2026
Avoid needlessly accessing ForwardRef.__forward_code__ in evaluate_forward_ref() #155278
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 6, 2026
@JelleZijlstra JelleZijlstra added the skip news label Aug 6, 2026
JelleZijlstra
JelleZijlstra approved these changes Aug 6, 2026
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As this is purely a performance optimization, let's only apply it on main (3.16).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Viicos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 6, 2026
Viicos
Viicos commented Aug 7, 2026
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Viicos
Apply suggestion from @Viicos
ca262b1
@JelleZijlstra
JelleZijlstra merged commit 5ffefdb into python:main Aug 7, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 7, 2026
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@Viicos @mbeijen
pythongh-155278: Avoid needlessly accessing `ForwardRef.__forward_cod…
9e904f7 
…e__` in `evaluate_forward_ref()` (python#155279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Viicos @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.