GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81954: Use lazy import warnings in zipfile by vstinner · Pull Request #155326 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 7, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since there is "lazy import warnings" at top level, it's no longer needed to import warnings explicitly in other places.

  • Issue: ValueError: I/O operation on closed file. in ZipFile destructor #81954

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-81954: Use lazy import warnings in zipfile
82aa2b4 
Since there is "lazy import warnings" at top level, it's no longer
needed to import warnings explicitly in other places.
@vstinner vstinner added the skip news label Aug 7, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 7, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 7, 2026
ValueError: I/O operation on closed file. in ZipFile destructor #81954
Closed
@vstinner

vstinner commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

@cmaloney: Would you mind to review my change?

After I merged your PR gh-152354, I looked at zipfile (when testing your change), and I noticed these "import warnings" lines which are no longer needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Aug 7, 2026
gh-81954: Warn when ZipFile is closed with unwritten data #152354
Merged
StanFromIreland
StanFromIreland approved these changes Aug 7, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 7, 2026
cmaloney
cmaloney approved these changes Aug 7, 2026
View reviewed changes
@vstinner
vstinner merged commit 7922b67 into python:main Aug 7, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the zipfile_warnings branch August 7, 2026 17:15
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 7, 2026
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@vstinner @mbeijen
pythongh-81954: Use lazy import warnings in zipfile (python#155326)
522f61d 
Since there is "lazy import warnings" at top level, it's no longer
needed to import warnings explicitly in other places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @cmaloney @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.