GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-102475: Fix os.path.realpath() for names which look like a drive by serhiy-storchaka · Pull Request #155399 · python/cpython Conversation
Member
The documentation says that in the non-strict mode the unresolved part of the path is appended, but it was joined with >>> ntpath.realpath('C:/spam/a:b')
'a:b'It is now simply appended, using the naive join suggested by @eryksun.
>>> ntpath.realpath('Z:spam') # Z: does not exist 'Z:spam' # now 'Z:\\spam'
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…rive The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
added a commit
that referenced
this pull request
…drive (GH-155399) (GH-156595) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. (cherry picked from commit 0c38e05) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
…drive (GH-155399) (GH-156594) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. (cherry picked from commit 0c38e05) Co-authored-by: Serhiy Storchaka <[email protected]>
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
…rive (pythonGH-155399) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does.
serhiy-storchaka
added a commit
that referenced
this pull request
…drive (GH-155399) (GH-156593) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. (cherry picked from commit 0c38e05) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 1 participantAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |