GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591) (GH-149071) by miss-islington · Pull Request #155440 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591)

Use ZipFile.extractall() to sanitize file names and extract files.

Files with invalid names (e.g. absolute paths) are now skipped.

Files containing ".." in the name are no longer skipped.
(cherry picked from commit 7ef7dd0)

Co-authored-by: Serhiy Storchaka [email protected]
(cherry picked from commit fc829e8)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @miss-islington
[3.11] pythongh-146581: Fix vulnerability in shutil.unpack_archive() …
04ef19f
…for ZIP files on Windows (pythonGH-146591) (pythonGH-149071)

pythongh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (pythonGH-146591)

Use ZipFile.extractall() to sanitize file names and extract files.

Files with invalid names (e.g. absolute paths) are now skipped.

Files containing ".." in the name are no longer skipped.
(cherry picked from commit 7ef7dd0)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit fc829e8)
@bedevere-app bedevere-app Bot mentioned this pull request Aug 9, 2026
shutil.unpack_archive() on Windows writes outside extract_dir for ZIP entries with drive-prefixed names #146581
Closed
@bedevere-app bedevere-app Bot added the type-security A security issue label Aug 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 9, 2026
[3.11] gh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (GH-146591) #149071
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Aug 9, 2026
@pablogsal
pablogsal enabled auto-merge (squash) August 9, 2026 16:33
@pablogsal
pablogsal disabled auto-merge August 9, 2026 18:51
@pablogsal
pablogsal enabled auto-merge (squash) August 9, 2026 18:51
@hugovk
Merge branch '3.10' into backport-7ef7dd0-3.10
87e4078
@hugovk

hugovk commented Aug 10, 2026

Copy link
Copy Markdown
Member

Windows should pass now #153610 is merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal merged commit 1071290 into python:3.10 Aug 10, 2026
14 of 15 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Aug 10, 2026
@miss-islington
miss-islington deleted the backport-7ef7dd0-3.10 branch August 10, 2026 07:33
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
@miss-islington @serhiy-storchaka @icanhasmath
[3.10] pythongh-146581: Fix vulnerability in shutil.unpack_archive() …
906bb52
…for ZIP files on Windows (pythonGH-146591) (pythonGH-149071) (python#155440)

[3.11] pythongh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (pythonGH-146591) (pythonGH-149071)

pythongh-146581: Fix vulnerability in shutil.unpack_archive() for ZIP files on Windows (pythonGH-146591)

Use ZipFile.extractall() to sanitize file names and extract files.

Files with invalid names (e.g. absolute paths) are now skipped.

Files containing ".." in the name are no longer skipped.
(cherry picked from commit 7ef7dd0)

(cherry picked from commit fc829e8)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 1071290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @hugovk @pablogsal @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.