GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-141174: Test `get_annotations()` on wrapped cyclical `functools.partial` by dr-carlos · Pull Request #155663 · python/cpython

Conversation

@dr-carlos

@dr-carlos dr-carlos commented Aug 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There is currently no test in test_annotationlib to get the annotations of a function f which is wrapped by a partial of itself, despite the behaviour being implemented in annotationlib:

cpython/Lib/annotationlib.py

Lines 1054 to 1055 in 025e7d2

if id(candidate) in _seen_ids:
break

This PR adds such a test based on the existing cyclical wrapper tests.

  • Issue: annotationlib: Improve test coverage #141174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dr-carlos
Test get_annotations() on wrapped cyclical functools.partial
8d8dd80
@dr-carlos
dr-carlos requested a review from JelleZijlstra as a code owner August 13, 2026 09:16
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Aug 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 13, 2026
annotationlib: Improve test coverage #141174
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 13, 2026
JelleZijlstra
JelleZijlstra approved these changes Aug 13, 2026
View reviewed changes
@JelleZijlstra JelleZijlstra added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 13, 2026
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 13, 2026
@JelleZijlstra JelleZijlstra added the skip news label Aug 13, 2026
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) August 13, 2026 14:17
@JelleZijlstra
JelleZijlstra merged commit 5d3f02a into python:main Aug 13, 2026
62 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 13, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155709 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 13, 2026
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155710 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2026
JelleZijlstra pushed a commit that referenced this pull request Aug 13, 2026
@miss-islington @dr-carlos
[3.14] gh-141174: Test get_annotations() on wrapped cyclical `funct…
5477222 
…ools.partial` (GH-155663) (#155710)

gh-141174: Test `get_annotations()` on wrapped cyclical `functools.partial` (GH-155663)

Test `get_annotations()` on wrapped cyclical `functools.partial`
(cherry picked from commit 5d3f02a)

Co-authored-by: dr-carlos <[email protected]>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@dr-carlos @mbeijen
pythongh-141174: Test get_annotations() on wrapped cyclical `functo…
8dd40b9 
…ols.partial` (python#155663)

Test `get_annotations()` on wrapped cyclical `functools.partial`
hugovk pushed a commit that referenced this pull request Aug 27, 2026
@miss-islington @dr-carlos
[3.15] gh-141174: Test get_annotations() on wrapped cyclical `funct…
94aa79c 
…ools.partial` (GH-155663) (#155709)

Co-authored-by: dr-carlos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dr-carlos @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.