GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30347: Fixed a crash in itertools.groupby() when use the grouper by serhiy-storchaka · Pull Request #1557 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 12, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

iterator in the key function.

https://bugs.python.org/issue30347

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-30347: Fixed a crash in itertools.groupby() when use the grouper
e2e6d4c 
iterator in the key function.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels May 12, 2017
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger May 12, 2017 13:41
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 12, 2017
@mention-bot

mention-bot commented May 12, 2017

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @kristjanvalur and @birkenfeld to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon reviewed May 12, 2017
View reviewed changes
Comment thread Misc/NEWS Outdated
Library
-------

- bpo-30347: Fixed a crash in itertools.groupby() when use the grouper iterator

@brettcannon brettcannon May 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"when using the grouper"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Fix a wording in Misc/NEWS.
1f8e81a
@rhettinger rhettinger self-assigned this May 12, 2017
@brettcannon brettcannon removed the needs backport to 3.5 label Aug 11, 2017
@serhiy-storchaka
serhiy-storchaka changed the base branch from master to 3.6 September 25, 2017 10:17
@serhiy-storchaka
serhiy-storchaka changed the base branch from 3.6 to master September 25, 2017 10:18
serhiy-storchaka added 3 commits September 25, 2017 14:05
@serhiy-storchaka
Move a NEWS entry to NEWS.d.
de1cf0b
@serhiy-storchaka
Merge branch 'master' into bpo30347
1830ea8
@serhiy-storchaka
Fix other crashes.
93940e4
@serhiy-storchaka
serhiy-storchaka merged commit c740e4f into python:master Sep 26, 2017
@miss-islington

miss-islington commented Sep 26, 2017

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the bpo30347 branch September 26, 2017 18:48
@miss-islington

miss-islington commented Sep 26, 2017

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c740e4fe8a9bc5815dc18c38d7f7600b128c3c51 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Sep 26, 2017
@bedevere-bot

bedevere-bot commented Sep 26, 2017

Copy link
Copy Markdown

GH-3770 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2017
@serhiy-storchaka @miss-islington
[3.6] bpo-30347: Stop crashes when concurrently iterate over itertool…
9735c8c 
…s.groupby() iterators. (pythonGH-1557)

(cherry picked from commit c740e4f)
serhiy-storchaka pushed a commit that referenced this pull request Sep 26, 2017
@miss-islington @serhiy-storchaka
[3.6] bpo-30347: Stop crashes when concurrently iterate over itertool…
69b2dc8 
…s.groupby() iterators. (GH-1557) (#3770)

(cherry picked from commit c740e4f)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 26, 2017
@serhiy-storchaka
[2.7] bpo-30347: Stop crashes when concurrently iterate over itertool…
669de14 
…s.groupby() iterators. (pythonGH-1557).

(cherry picked from commit c740e4f)
@bedevere-bot

bedevere-bot commented Sep 26, 2017

Copy link
Copy Markdown

GH-3772 is a backport of this pull request to the 2.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Sep 26, 2017
serhiy-storchaka added a commit that referenced this pull request Sep 26, 2017
@serhiy-storchaka
[2.7] bpo-30347: Stop crashes when concurrently iterate over itertool…
d0b9dc3 
…s.groupby() iterators. (GH-1557). (#3772)

(cherry picked from commit c740e4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@serhiy-storchaka @mention-bot @miss-islington @bedevere-bot @brettcannon @rhettinger @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.