GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-15999: Always pass bool instead of int to socket.setblocking(). by serhiy-storchaka · Pull Request #15621 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 30, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue15999

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-15999: Always pass bool instead of int to socket.setblocking().
dbf08ed
@serhiy-storchaka serhiy-storchaka added the skip news label Aug 30, 2019
@serhiy-storchaka
serhiy-storchaka requested review from 1st1, asvetlov and tiran as code owners August 30, 2019 21:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 30, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Aug 30, 2019
@serhiy-storchaka
serhiy-storchaka merged commit 5eca7f3 into python:master Sep 1, 2019
@serhiy-storchaka
serhiy-storchaka deleted the use-bools-socket-setblocking branch September 1, 2019 09:12
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 1, 2019
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@serhiy-storchaka @lisroach
bpo-15999: Always pass bool instead of int to socket.setblocking(). (p…
3e89802 
…ythonGH-15621)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@serhiy-storchaka @DinoV
bpo-15999: Always pass bool instead of int to socket.setblocking(). (p…
22a6ce2 
…ythonGH-15621)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@serhiy-storchaka @websurfer5
bpo-15999: Always pass bool instead of int to socket.setblocking(). (p…
7c9af02 
…ythonGH-15621)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 3, 2022
Using new 'bool' format character #60203
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.