GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-155648: Fix IDLE tests that cannot fail by terryjreedy · Pull Request #156257 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Aug 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

DD bug 26:
test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.

test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-#156260 add real tests.

template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.

  • Issue: IDLE: Fix devdanzin test issues #155648

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-155648: Fix IDLE tests that cannot fail
d5092ba 
DD bug 26:
test_autocomplete.py:241 passes when proper because `any([]) is
True` is true.  It would also pass if is small only had underscored
words because the filter got reversed.  Change logic and replace
filter with generator expressions.

test_editor.py:236 and test_configdialog.py:55 have empty tests
('pass'); comment them out.
template.py:25 tests `True == True`; make another comparison.
The template fix still might fail the bug scanner, but does not
matter.  It is not run, and might not be needed any longer.
@terryjreedy
terryjreedy requested a review from serhiy-storchaka August 23, 2026 05:59
@terryjreedy terryjreedy added skip news topic-IDLE needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 23, 2026
IDLE: Fix devdanzin test issues #155648
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 23, 2026
serhiy-storchaka
serhiy-storchaka reviewed Aug 23, 2026
View reviewed changes
Comment thread Lib/idlelib/idle_test/test_autocomplete.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/idle_test/test_editor.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Aug 23, 2026
View reviewed changes
Comment thread Lib/idlelib/idle_test/template.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 23, 2026
gh-155648: Write the empty and placeholder IDLE tests #156260
Merged
@serhiy-storchaka

serhiy-storchaka commented Aug 23, 2026

Copy link
Copy Markdown
Member

See #156260 which implements the tests instead of commenting them out.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Respond to comments.
5160ed0
@terryjreedy

terryjreedy commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

I made a change in each file. Please re-review. I would like to merge this now as a minimal fix, and include 3.15 in the backports. I looked at the +300 lines of real tests and would like to defer them until 3.15 is unlocked.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Aug 23, 2026
View reviewed changes
Comment thread Lib/idlelib/idle_test/test_autocomplete.py Outdated
Comment on lines 233 to 234

@serhiy-storchaka serhiy-storchaka Aug 23, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between these lines...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/idlelib/idle_test/test_autocomplete.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Signed-off-by: Terry Jan Reedy <[email protected]>
e4614b7
serhiy-storchaka
serhiy-storchaka approved these changes Aug 23, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 23, 2026
@terryjreedy
terryjreedy merged commit ee1da7e into python:main Aug 24, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Aug 24, 2026

Copy link
Copy Markdown

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 24, 2026
@bedevere-app

bedevere-app Bot commented Aug 24, 2026

Copy link
Copy Markdown

GH-156315 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 24, 2026
@bedevere-app

bedevere-app Bot commented Aug 24, 2026

Copy link
Copy Markdown

GH-156316 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 24, 2026
@bedevere-app

bedevere-app Bot commented Aug 24, 2026

Copy link
Copy Markdown

GH-156317 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 24, 2026
@terryjreedy
terryjreedy deleted the ddbug26 branch August 24, 2026 14:25
@terryjreedy

terryjreedy commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

Serhiy, thank you for review. Original patch 'worked'; reviewed result is better for each file changed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy added a commit that referenced this pull request Aug 24, 2026
@miss-islington @terryjreedy
[3.13] gh-155648: Fix IDLE tests that cannot fail (GH-156257) (#156317)
708b457 
gh-155648: Fix IDLE tests that cannot fail (GH-156257)

test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.

test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-GH-156260 add real tests.

template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.

Remove duplicate and confusing fetch_completions call.
(cherry picked from commit ee1da7e)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Aug 24, 2026
@miss-islington @terryjreedy
[3.14] gh-155648: Fix IDLE tests that cannot fail (GH-156257) (#156316)
7cc0932 
gh-155648: Fix IDLE tests that cannot fail (GH-156257)

test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.

test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-GH-156260 add real tests.

template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.

Remove duplicate and confusing fetch_completions call.
(cherry picked from commit ee1da7e)

Co-authored-by: Terry Jan Reedy <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 24, 2026
@serhiy-storchaka @claude
Remove the skips added for the empty tests
3b3ae5b 
RMenuTest and ConfigDialogTest were skipped as empty in pythonGH-156257.
They are no longer empty.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@terryjreedy terryjreedy removed the skip news label Aug 25, 2026
hugovk pushed a commit that referenced this pull request Aug 27, 2026
@miss-islington @terryjreedy
[3.15] gh-155648: Fix IDLE tests that cannot fail (GH-156257) (#156315)
96ae61d 
Co-authored-by: Terry Jan Reedy <[email protected]>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Aug 27, 2026
@terryjreedy @clin1234
pythongh-155648: Fix IDLE tests that cannot fail (python#156257)
ea0a47c 
test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.

test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-python#156260 add real tests.

template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.

Remove duplicate and confusing fetch_completions call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-IDLE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@terryjreedy @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.