GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151126: set `MemoryError` on allocation failure in CJK codec macros by KowalskiThomas · Pull Request #156292 · python/cpython

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Aug 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Relates to #151126.

  • Issue: Many places have missing PyErr_NoMemory() call after failing memory allocation #151126

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KowalskiThomas
pythongh-151126: Set MemoryError on alloc failure in CJK codec macros
6ae41c8
@bedevere-app bedevere-app Bot mentioned this pull request Aug 23, 2026
Many places have missing PyErr_NoMemory() call after failing memory allocation #151126
Open
@KowalskiThomas
KowalskiThomas marked this pull request as ready for review August 23, 2026 20:00
@KowalskiThomas
KowalskiThomas requested a review from corona10 as a code owner August 23, 2026 20:00
@bedevere-app bedevere-app Bot added the awaiting review label Aug 23, 2026
@KowalskiThomas KowalskiThomas changed the title gh-151126: Set MemoryError on allocation failure in CJK codec macros gh-151126: set MemoryError on allocation failure in CJK codec macros Oct 24, 2026
StanFromIreland
StanFromIreland approved these changes Oct 25, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2026-08-23-16-33-00.gh-issue-151126.GUvtG7.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 25, 2026
@StanFromIreland
Update Misc/NEWS.d/next/Library/2026-08-23-16-33-00.gh-issue-151126.G…
f8cf4fb 
…UvtG7.rst
@StanFromIreland
StanFromIreland enabled auto-merge (squash) October 25, 2026 16:53
@StanFromIreland
Merge branch 'main' into kowalski/add-check-cjkcodecs-macros
f1f3c68
@StanFromIreland
StanFromIreland merged commit d441a11 into python:main Oct 25, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 25, 2026
@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 25, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @KowalskiThomas for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @KowalskiThomas for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160673 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 25, 2026
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160674 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 25, 2026
StanFromIreland added a commit that referenced this pull request Oct 25, 2026
@miss-islington @KowalskiThomas @StanFromIreland
[3.14] gh-151126: Set MemoryError on allocation failure in CJK code…
a5892db 
…c macros (GH-156292) (#160673)

(cherry picked from commit d441a11)

Co-authored-by: Thomas Kowalski <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland added a commit that referenced this pull request Oct 25, 2026
@miss-islington @KowalskiThomas @StanFromIreland
[3.15] gh-151126: Set MemoryError on allocation failure in CJK code…
c6e7431 
…c macros (GH-156292) (#160674)

(cherry picked from commit d441a11)

Co-authored-by: Thomas Kowalski <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@KowalskiThomas @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.