GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS by advitrocks9 · Pull Request #156302 · python/cpython

Conversation

advitrocks9 commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

The 3.15 What's New lists urlsafe_b64decode() as one of the decoders that got canonical, but it never got the parameter:

>>> base64.urlsafe_b64decode(b'aGk=', canonical=True)
TypeError: urlsafe_b64decode() got an unexpected keyword argument 'canonical'

It doesn't call b64decode(), it calls binascii.a2b_base64() directly with a fixed set of arguments, so widening b64decode() in GH-146312 didn't affect it. This drops it from the bullet, per gpshead on the issue.

I went through the other bullets in the base64 section and checked them against the signatures. This is the only one that's off.

The NEWS entry for the same change (now in Misc/NEWS.d/3.15.0b1.rst) says the base16 decoders got canonical, but none did: b16decode() and binascii.a2b_hex() are unchanged. Removed base16 from that entry too.

Docs only, so skip news. Needs a backport to 3.15.

Issue: Incorrect 3.15 what's new entry for base64 module #155193

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-155193: Remove urlsafe_b64decode from the *canonical* entry …

76d3d91

…in What's New 3.15

advitrocks9 requested a review from AA-Turner as a code owner

August 23, 2026 20:33

bedevere-app Bot added the docs Documentation in the Doc dir label

Aug 23, 2026

python-cla-bot Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the skip news label

Aug 23, 2026

github-project-automation Bot added this to Docs PRs

Aug 23, 2026

github-project-automation Bot moved this to Todo in Docs PRs

Aug 23, 2026

bedevere-app Bot mentioned this pull request

Aug 23, 2026

Incorrect 3.15 what's new entry for base64 module #155193

Closed

bedevere-app Bot added the awaiting review label

Aug 23, 2026

read-the-docs-community Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34196934 | 📁 Comparing c5bf8b9 against main (53d2e14)

🔍 Preview build

2 files changed

± whatsnew/3.15.html
± whatsnew/changelog.html

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz commented Aug 23, 2026

Copy link

Copy Markdown

Member

Can you check if a NEWS entry needs to be amended as well?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          pythongh-155193: Drop base16 from the pythongh-146311 NEWS entry

c5bf8b9

advitrocks9 changed the title ~~gh-155193: Remove urlsafe_b64decode from the *canonical* entry in What's New 3.15~~ gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS

Aug 23, 2026

advitrocks9 commented Aug 23, 2026

Copy link

Copy Markdown

Contributor Author

The NEWS entry doesn't name urlsafe_b64decode(), so it doesn't have the What's New problem. It says base16 got canonical, and it didn't. b16decode() and binascii.a2b_hex() are unchanged, GH-146312 never touched them. Removed base16 from the entry in this PR.

Separately, the binascii bullet in What's New only lists a2b_base64(), but a2b_base32(), a2b_ascii85() and a2b_base85() also got the parameter. Can add them here or in a separate PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz commented Aug 23, 2026

Copy link

Copy Markdown

Member

Nah for What's New it's ok.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz requested a review from gpshead

August 23, 2026 22:02

gpshead approved these changes

Aug 24, 2026

View reviewed changes

gpshead left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on base16 being errantly listed as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Aug 24, 2026

advitrocks9 commented Aug 25, 2026

Copy link

Copy Markdown

Contributor Author

@AA-Turner is this good to be merged?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk merged commit 5f31aee into python:main

Aug 25, 2026

34 checks passed

Uh oh!

There was an error while loading. Please reload this page.

github-project-automation Bot moved this from Todo to Done in Docs PRs

Aug 25, 2026

bedevere-app Bot removed the awaiting merge label

Aug 25, 2026

hugovk added the needs backport to 3.15 bugs and security fixes label

Aug 25, 2026

miss-islington-app Bot commented Aug 25, 2026

Copy link

Copy Markdown

Thanks @advitrocks9 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Aug 25, 2026

Copy link

Copy Markdown

GH-156370 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Aug 25, 2026

hugovk pushed a commit that referenced this pull request

Aug 25, 2026


          [3.15] gh-155193: Fix the *canonical* decoder lists in the 3.15 What'…

747e518

…s New and NEWS (GH-156302) (#156370)

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS (GH-156302)
(cherry picked from commit 5f31aee)

Co-authored-by: Advit Arora <[email protected]>

clin1234 pushed a commit to clin1234/cpython that referenced this pull request

Aug 27, 2026


          pythongh-155193: Fix the *canonical* decoder lists in the 3.15 What's…

4fcf430

… New and NEWS (python#156302)

Reviewers

gpshead

gpshead approved these changes

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

Docs PRs

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

advitrocks9 commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

read-the-docs-community Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

picnixz commented Aug 23, 2026

Uh oh!

advitrocks9 commented Aug 23, 2026

Uh oh!

picnixz commented Aug 23, 2026

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

advitrocks9 commented Aug 25, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Aug 25, 2026

Uh oh!

bedevere-app Bot commented Aug 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

advitrocks9 commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

python-cla-bot Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

read-the-docs-community Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.