GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156243: Indicate that emscripten_runtime depends on stringToNewUTF8 by hoodmane · Pull Request #156335 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Aug 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Resolves #156243.

  • Issue: embedding CPython in emscripten build requires stringToNewUTF8 symbol #156243

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-156243: Use EM_JS_DEPS to indicate that emscripten_runtime d…
0a7775a 
…epends on stringToNewUTF8
@hoodmane
hoodmane requested a review from ericsnowcurrently as a code owner August 24, 2026 21:16
@bedevere-app bedevere-app Bot mentioned this pull request Aug 24, 2026
embedding CPython in emscripten build requires stringToNewUTF8 symbol #156243
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 24, 2026
@hoodmane hoodmane added skip news OS-emscripten and removed awaiting review labels Aug 24, 2026
@hoodmane
hoodmane requested review from freakboy3742 and removed request for ericsnowcurrently August 24, 2026 21:16
freakboy3742
freakboy3742 approved these changes Aug 25, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@hoodmane Given the original report was against 3.15.0rc1, I presume this should be back ported to at least 3.15, and possibly 3.14 as well to 3.15 (3.14 doesn't appear to have the affected code)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoodmane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added the awaiting merge label Aug 25, 2026
@hoodmane hoodmane added 3.15 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed 3.15 bugs and security fixes labels Aug 25, 2026
@hoodmane

hoodmane commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Agreed, I added a "needs backport" label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
freakboy3742 merged commit 05eac89 into python:main Aug 25, 2026
67 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 25, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

GH-156383 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 25, 2026
@hoodmane
hoodmane deleted the emjs-deps-emscripten-runtime branch August 25, 2026 21:59
hugovk pushed a commit that referenced this pull request Aug 27, 2026
@miss-islington @hoodmane
[3.15] gh-156243: Indicate that emscripten_runtime depends on stringT…
7d10c8d 
…oNewUTF8 (GH-156335) (#156383)

Co-authored-by: Hood Chatham <[email protected]>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Aug 27, 2026
@hoodmane @clin1234
pythongh-156243: Indicate that emscripten_runtime depends on stringTo…
044eead 
…NewUTF8 (python#156335)

Add an explicit declaration an Emscripten dependency on the stringToNewUTF8
library function.
@hoodmane hoodmane mentioned this pull request Sep 1, 2026
gh-156780: Emscripten: add missing EM_JS_DEPS #156798
Merged
@clementperon clementperon mentioned this pull request Oct 8, 2026
[depends][python][wasm] build and run a statically linked CPython xbmc/xbmc#29169
Merged
3 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

embedding CPython in emscripten build requires stringToNewUTF8 symbol

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.