GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-144446: Fix _PyFrame_GetFrameObject() for test_cppext (C++) by vstinner · Pull Request #156893 · python/cpython Conversation
|
|
test_cppext started to fail on AMD64 Alpine Linux NoGIL 3.x: https://buildbot.python.org/#/builders/1819/builds/2983 commit db92901 introduced this change: - PyFrameObject *res = frame->frame_obj; + PyFrameObject *res = FT_ATOMIC_LOAD_PTR_ACQUIRE(frame->frame_obj); |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
test_cppext also fails on the "AMD64 CentOS9 NoGIL 3.x" buildbot since the build: https://buildbot.python.org/#/builders/1609/builds/6887 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
!buildbot AMD64 CentOS9 NoGIL |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 633171b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156893%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
!buildbot AMD64 Alpine Linux NoGIL PR |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 633171b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156893%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
test_cppext passed on "buildbot/AMD64 CentOS9 NoGIL PR". I merged my PR. Thanks for the review @kumaraditya303. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ython#156893) Do an explicit cast to fix the C++ compiler warning: In file included from Include/internal/pycore_object.h:13, from Include/internal/pycore_cell.h:5, from extension.cpp:29: Include/internal/pycore_interpframe.h: In function 'PyFrameObject* _PyFrame_GetFrameObject(_PyInterpreterFrame*)': Include/internal/pycore_pyatomic_ft_wrappers.h:33:32: error: invalid conversion from 'void*' to 'PyFrameObject*' {aka '_frame*'} [-fpermissive] 33 | _Py_atomic_load_ptr_acquire(&value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ | | | void* Include/internal/pycore_interpframe.h:348:26: note: in expansion of macro 'FT_ATOMIC_LOAD_PTR_ACQUIRE' 348 | PyFrameObject *res = FT_ATOMIC_LOAD_PTR_ACQUIRE(frame->frame_obj); | ^~~~~~~~~~~~~~~~~~~~~~~~~~
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.