GeezerVison is showing github.com — gh-129813: Fix typo in byteswriter_resize() by vstinner · Pull Request #156938 · python/cpython
Conversation
vstinner
commented
Sep 4, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The intent is to test "resize and overallocate", even if in practice "resize & overallocate" is the same (both variables are either 0 or 1). Use "&&" to better describe the intent of the test.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The intent is to test "resize and overallocate", even if in practice
"resize & overallocate" is the same (both variables are either 0 or
1). Use "&&" to better describe the intent of the test.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot AMD64 Windows11 Non-Debug 3.x (tier-1) has failed when building commit 5141621.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/914/builds/6044) and take a look at the build logs.
- Check if the failure is related to this commit (5141621) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/914/builds/6044
Failed tests:
Failed subtests:
- test_wmi_query_repeated - test.test_wmi.WmiTests.test_wmi_query_repeated
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_wmi.py", line 41, in test_wmi_query_repeated
self.test_wmi_query_os_version()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_wmi.py", line 30, in test_wmi_query_os_version
self.assertEqual(1, len(r))
~~~~~~~~~~~~~~~~^^^^^^^^^^^
AssertionError: 1 != 5
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk
pushed a commit
that referenced
this pull request
Sep 5, 2026
gh-129813: Fix typo in byteswriter_resize() (GH-156938)
The intent is to test "resize and overallocate", even if in practice
"resize & overallocate" is the same (both variables are either 0 or
1). Use "&&" to better describe the intent of the test.
(cherry picked from commit 5141621)
Co-authored-by: Victor Stinner <[email protected]>
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Sep 12, 2026
The intent is to test "resize and overallocate", even if in practice
"resize & overallocate" is the same (both variables are either 0 or
1). Use "&&" to better describe the intent of the test.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|