GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-156924: Try reifying lazy imports in `ForwarRef.evaluate()` (GH-156940) by miss-islington · Pull Request #157224 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 9, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 52ffffe)

Co-authored-by: Victorien [email protected]
Co-authored-by: Jelle Zijlstra [email protected]
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Bartosz Sławecki [email protected]

  • Issue: Lazy imports and resolving type hints #156924

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Viicos @JelleZijlstra
@encukou @johnslavik @miss-islington
pythongh-156924: Try reifying lazy imports in ForwarRef.evaluate() (p…
d791036 
…ythonGH-156940)

(cherry picked from commit 52ffffe)

Co-authored-by: Victorien <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>
@miss-islington
miss-islington requested a review from JelleZijlstra as a code owner September 9, 2026 15:13
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2026
Lazy imports and resolving type hints #156924
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Sep 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2026
gh-156924: Try reifying lazy imports in ForwarRef.evaluate() #156940
Merged
JelleZijlstra
JelleZijlstra approved these changes Sep 9, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 9, 2026
@JelleZijlstra

JelleZijlstra commented Sep 9, 2026

Copy link
Copy Markdown
Member

@encukou would you mind reviewing this backport so it can go into 3.15 final?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Sep 10, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with this part of the codebase, but, it makes sense to me and I couldn't find an issue.

Not sure it's the kind of emergency fix to go in a RC; that's @hugovk's call.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Sep 10, 2026

Copy link
Copy Markdown
Member

This is okay for the final.
encukou reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 013c4ae into python:3.15 Sep 10, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 10, 2026
@miss-islington
miss-islington deleted the backport-52ffffe-3.15 branch September 10, 2026 10:17
Kronuz pushed a commit to Kronuz/cpython that referenced this pull request Oct 5, 2026
@miss-islington @Viicos
@JelleZijlstra @encukou @johnslavik @Kronuz
[3.15] pythongh-156924: Try reifying lazy imports in `ForwarRef.evalu…
7263e28 
…ate()` (pythonGH-156940) (python#157224)

Co-authored-by: Victorien <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>
(cherry picked from commit 013c4ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @JelleZijlstra @hugovk @encukou @Viicos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.