GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-157368: Fix clang-cl version in sys.version on Windows by chris-eibl · Pull Request #157369 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Sep 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Fix clang-cl version in sys.version on Windows #157368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chris-eibl
chris-eibl requested a review from a team as a code owner September 12, 2026 17:02
@python-cla-bot

python-cla-bot Bot commented Sep 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2026
_io.FileIO uses a quadratic-time buffer growth algorithm #57368
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 12, 2026
@chris-eibl chris-eibl changed the title gh-57368: Fix clang-cl version in sys.version on Windows gh-157368: Fix clang-cl version in sys.version on Windows Sep 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2026
Fix clang-cl version in sys.version on Windows #157368
Closed
@chris-eibl

This comment was marked as outdated.

Sign in to view
@chris-eibl
fix clang compiler version in _Py_COMPILER
672a4f7
@chris-eibl
chris-eibl force-pushed the fix_clang_version branch from 8071160 to 672a4f7 Compare September 12, 2026 17:17
@chris-eibl

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@chris-eibl

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@chris-eibl

chris-eibl commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

!buildbot Windows

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Sep 12, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @chris-eibl for commit 672a4f7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157369%2Fmerge

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows Server 2025 Refleaks PR
  • AMD64 Windows Server 2025 Clang PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows PGO PR
  • AMD64 Windows PGO NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland
StanFromIreland reviewed Sep 12, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2026-09-12-18-59-21.gh-issue-157368.2DirHP.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Library/2026-09-12-18-59-21.gh-issue-157368.2DirHP.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread PC/pyconfig.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

chris-eibl and others added 2 commits September 12, 2026 21:50
@chris-eibl @StanFromIreland
Update Misc/NEWS.d/next/Library/2026-09-12-18-59-21.gh-issue-157368.2…
7cd5f4c
…DirHP.rst

Co-authored-by: Stan Ulbrych <[email protected]>
@chris-eibl @StanFromIreland
Update PC/pyconfig.h
a97eec8
Co-authored-by: Stan Ulbrych <[email protected]>
@chris-eibl chris-eibl added the OS-unsupported label Sep 12, 2026
@github-project-automation github-project-automation Bot added this to Unsupported platforms Sep 12, 2026
@chris-eibl chris-eibl moved this to In Progress in Unsupported platforms Sep 12, 2026
@zware

zware commented Sep 12, 2026

Copy link
Copy Markdown
Member

!buildbot Windows.*Clang

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Sep 12, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit a97eec8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157369%2Fmerge

The command will test the builders whose names match following regular expression: Windows.*Clang

The builders matched are:

  • AMD64 Windows Server 2025 Clang PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chris-eibl
move news to Windows
91e94e5
StanFromIreland
StanFromIreland approved these changes Sep 13, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 13, 2026
@zware
zware merged commit 0ba7be9 into python:main Sep 13, 2026
102 of 104 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 13, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unsupported platforms Sep 13, 2026
@zware zware added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 13, 2026
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned zware Sep 13, 2026
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.15
zware and StanFromIreland reacted with confused emoji
All reactions
  • 😕 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware zware removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 13, 2026
@chris-eibl

chris-eibl commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

Yeah, some things have changed, but it's very easy to manual backport. Will do 3.15 and 3.14 in the upcoming days,.

3.13 if deemed reasonable - but that was before my engangement wrt clang so I have no idea about the status there.

zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chris-eibl
chris-eibl deleted the fix_clang_version branch September 14, 2026 05:16
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@chris-eibl @StanFromIreland @johnslavik
pythongh-157368: Fix clang-cl version in sys.version on Windows (pyth…
6bb1710
…onGH-157369)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

GH-157565 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 15, 2026
@bedevere-app

bedevere-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

GH-157569 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware

zware commented Sep 15, 2026

Copy link
Copy Markdown
Member

I think it's fine not to go back to 3.13; I added that label optimistically, and wasn't going to bother with a backport if it didn't go automatically :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chris-eibl

chris-eibl commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

Hm, actually the manual backport to 3.13 was as simple as the others, but newer clang's now raise errors instead of warnings for incompatible pointers, so #131600 and #131595 would need to be backported, too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Sep 16, 2026

Copy link
Copy Markdown

GH-157606 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chris-eibl

chris-eibl commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

When creating the issue I've tested 3.14 successfully with a release build, but the buildbot uses a debug build which fails test.test_call.TestRecursion.test_margin_is_sufficient. I can reproduce locally: we do not use -Og yet for clang-cl, and thus consume a lot more stack. It's a very simple PR I'm gonna do the next days ...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk pushed a commit that referenced this pull request Sep 17, 2026
@chris-eibl @StanFromIreland
[3.15] gh-157368: Fix clang-cl version in sys.version on Windows (GH-…
5a1180c
…157369) (#157565)

Co-authored-by: Stan Ulbrych <[email protected]>
@vstinner vstinner mentioned this pull request Oct 8, 2026
gh-158948: Generate Modules/getbuildinfo.h #158951
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zware zware

Labels

OS-unsupported

Projects

Unsupported platforms
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@chris-eibl @bedevere-bot @zware @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.