GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128509: Add tests on sys._is_immortal() by vstinner · Pull Request #157376 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 12, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add an API for determining if an object is immortal #128509

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-128509: Add tests on sys._is_immortal()
d2edd60
@vstinner vstinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 12, 2026
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2026
Add an API for determining if an object is immortal #128509
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 12, 2026
@vstinner

vstinner commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

@ZeroIntensity: As the sys._is_immortal() author, would you mind to review my tests please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Sep 12, 2026
ZeroIntensity
ZeroIntensity reviewed Sep 13, 2026
View reviewed changes
Comment thread Lib/test/test_sys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Workaround marshal limitation
3ac1ba1
@vstinner

vstinner commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

test_sys fails if Lib/test/__pycache__/test_sys.cpython-316.pyc cache already exists. The problem is that the marshal module is unable to get 1-byte string singletons. I wrote PR gh-157398 to enhance the marshal module.

I would prefer to fix the marshal module and then update this PR to remove the workaround that I just pushed.
ZeroIntensity reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 2 commits September 13, 2026 14:20
@vstinner
Merge branch 'main' into is_immortal
556407d
@vstinner
Revert marshal workaround
d588cc2 
marshal has been fixed
ZeroIntensity
ZeroIntensity approved these changes Sep 13, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 13, 2026
@vstinner
vstinner merged commit fb46c67 into python:main Sep 13, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the is_immortal branch September 13, 2026 18:13
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 13, 2026
@bedevere-app

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157445 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 13, 2026
@bedevere-app

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157446 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 13, 2026
@vstinner

vstinner commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

Merged, thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Sep 13, 2026
@miss-islington @vstinner
[3.14] gh-128509: Add tests on sys._is_immortal() (GH-157376) (#157446)
fceb517 
gh-128509: Add tests on sys._is_immortal() (GH-157376)
(cherry picked from commit fb46c67)

Co-authored-by: Victor Stinner <[email protected]>
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@vstinner @johnslavik
pythongh-128509: Add tests on sys._is_immortal() (python#157376)
169470f
vstinner added a commit that referenced this pull request Oct 9, 2026
@miss-islington @vstinner
[3.15] gh-128509: Add tests on sys._is_immortal() (GH-157376) (#157445)
4911737 
gh-128509: Add tests on sys._is_immortal() (GH-157376)
(cherry picked from commit fb46c67)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.