GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156939: Detect PyBytesWriter buffer overflow earlier by vstinner · Pull Request #157385 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Check the canary byte in all PyBytesWriter methods, not only in PyBytesWriter_Finish().

Add a discard() method to the _testcapi wrapper.

  • Issue: C API: Detect buffer overflow in PyBytesWriter #156939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-156939: Detect PyBytesWriter buffer overflow earlier
169f4c6 
Check the canary byte in all PyBytesWriter methods, not only in
PyBytesWriter_Finish().

Add a discard() method to the _testcapi wrapper.
@vstinner vstinner added the skip news label Sep 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 13, 2026
C API: Detect buffer overflow in PyBytesWriter #156939
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 13, 2026
vstinner added 2 commits September 13, 2026 04:41
@vstinner
Fix test_grow_error()
e0553d7
@vstinner
Fix test_decodeescape()
8286c99
@vstinner
vstinner merged commit 58cdff7 into python:main Sep 13, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the check_canary branch September 13, 2026 03:47
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 13, 2026
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@vstinner @johnslavik
pythongh-156939: Detect PyBytesWriter buffer overflow earlier (python…
3dd42b1 
…#157385)

Check the canary byte in all PyBytesWriter methods, not only in
PyBytesWriter_Finish().

Add a discard() method to the _testcapi wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.