GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156388: Docs: clarify DocumentType identifiers by Neiland85 · Pull Request #157646 · python/cpython

Conversation

@Neiland85

@Neiland85 Neiland85 commented Sep 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs #156388

Clarify the documented relationship between DocumentType.publicId and systemId for parsed XML documents, including PUBLIC and SYSTEM declarations, and note that createDocumentType() does not validate identifier combinations for programmatically created objects.

This covers only the publicId/systemId mapping. Other remaining items in #156388 are out of scope.

  • Issue: xml.dom docs are missing important information necessary for usage #156388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Sep 16, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Sep 16, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Sep 16, 2026
@Neiland85 Neiland85 changed the title Docs: clarify DocumentType identifiers gh-156388: Docs: clarify DocumentType identifiers Sep 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 16, 2026
xml.dom docs are missing important information necessary for usage #156388
Open
16 of 19 tasks
@Neiland85

Neiland85 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for confirming this point in the issue discussion. I’ve submitted #157646 to document that mapping explicitly.

For parsed XML documents, the combinations correspond as follows:

  • publicId and systemId non-None → PUBLIC
  • publicId is None, systemId non-None → SYSTEM
  • both are None → no external identifier
  • publicId non-None, systemId None → not produced by parsing a valid XML DOCTYPE

I also noted in the PR that createDocumentType() does not validate the identifiers, so programmatically created DocumentType objects may have other combinations.

I’ll leave the PR open for maintainer review and follow any requested changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Neiland85
Docs: clarify DocumentType identifiers
fbdb382
@Neiland85
Neiland85 force-pushed the docs-xml-dom-156388 branch from bc6be00 to fbdb382 Compare September 19, 2026 03:53
@read-the-docs-community

read-the-docs-community Bot commented Sep 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34771797 | 📁 Comparing 7e5a837 against main (6dad8b8)

  🔍 Preview build  

33 files changed · + 1 added · ± 32 modified

+ Added

  • library/dialog.html

± Modified

  • builtins/functions.html
  • c-api/hash.html
  • c-api/init_config.html
  • c-api/interp-lifecycle.html
  • c-api/module.html
  • c-api/slice.html
  • c-api/stable.html
  • c-api/threads.html
  • c-api/unicode.html
  • deprecations/c-api-pending-removal-in-future.html
  • and 22 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Neiland85
Merge remote-tracking branch 'upstream/main' into docs-xml-dom-156388
7e5a837
@Neiland85

Neiland85 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Hi, just following up on this documentation PR. It clarifies the DocumentType.publicId / systemId combinations for parsed XML documents and notes the behavior of createDocumentType() for programmatically created objects.

The documentation preview is available, and I’m happy to revise the wording if anything needs clarification. Thanks for your time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Neiland85
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.