GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156939: Add tests on the PyUnicode C API by vstinner · Pull Request #157798 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add tests on functions:

  • PyUnicode_CHECK_INTERNED()
  • PyUnicode_Check()
  • PyUnicode_CheckExact()
  • PyUnicode_Equal()
  • PyUnicode_GET_LENGTH()
  • PyUnicode_IS_ASCII()
  • PyUnicode_IS_COMPACT()
  • PyUnicode_IS_COMPACT_ASCII()
  • PyUnicode_KIND()
  • PyUnicode_MAX_CHAR_VALUE()
  • PyUnicode_READ()
  • PyUnicode_READ_CHAR()
  • PyUnicode_WRITE()

Add test on PyUnicode_FromOrdinal(0).

Require _testcapi module in test_capi.test_unicode. Since _testcapi is specific to CPython, remove @support.cpython_only.

  • Issue: C API: Detect buffer overflow in PyBytesWriter #156939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner vstinner added the skip news label Sep 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2026
C API: Detect buffer overflow in PyBytesWriter #156939
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 19, 2026
@vstinner
pythongh-156939: Add tests on the PyUnicode C API
e0d8fd5
Add tests on functions:

* PyUnicode_CHECK_INTERNED()
* PyUnicode_Check()
* PyUnicode_CheckExact()
* PyUnicode_Equal()
* PyUnicode_GET_LENGTH()
* PyUnicode_IS_ASCII()
* PyUnicode_IS_COMPACT()
* PyUnicode_IS_COMPACT_ASCII()
* PyUnicode_KIND()
* PyUnicode_MAX_CHAR_VALUE()
* PyUnicode_READ()
* PyUnicode_READ_CHAR()
* PyUnicode_WRITE()

Add test on PyUnicode_FromOrdinal(0).

Require _testcapi module in test_capi.test_unicode. Since _testcapi
is specific to CPython, remove @support.cpython_only.
@vstinner
vstinner force-pushed the unicode_testcapi branch from aa13241 to e0d8fd5 Compare September 19, 2026 14:59
vstinner added 4 commits September 19, 2026 17:06
@vstinner
Move imports at the top
851bce7
@vstinner
Add comments on tested functions
f53a1da
@vstinner
Cleanup
b049b60
@vstinner
Add CRASHES comments
7a034e4
@vstinner
vstinner enabled auto-merge (squash) September 19, 2026 15:37
@vstinner
vstinner merged commit e8f6448 into python:main Sep 19, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the unicode_testcapi branch September 19, 2026 16:08
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 19, 2026
vstinner added a commit that referenced this pull request Oct 16, 2026
@vstinner
[3.15] gh-156939: Add tests on the PyUnicode C API (#159533)
bcbe9bc
* gh-142217: Add tests on the deprecated _Py_Identifier C API (#157638)

(cherry picked from commit 21403af)

* gh-156939: Add tests on the PyUnicode C API (#157798)

Add tests on functions:

* PyUnicode_CHECK_INTERNED()
* PyUnicode_Check()
* PyUnicode_CheckExact()
* PyUnicode_Equal()
* PyUnicode_GET_LENGTH()
* PyUnicode_IS_ASCII()
* PyUnicode_IS_COMPACT()
* PyUnicode_IS_COMPACT_ASCII()
* PyUnicode_KIND()
* PyUnicode_MAX_CHAR_VALUE()
* PyUnicode_READ()
* PyUnicode_READ_CHAR()
* PyUnicode_WRITE()

Changes:

* Add test on PyUnicode_FromOrdinal(0).
* Require _testcapi module in test_capi.test_unicode. Since _testcapi
  is specific to CPython, remove @support.cpython_only.

(cherry picked from commit e8f6448)
@vstinner vstinner mentioned this pull request Oct 16, 2026
[3.14] gh-156939: Add tests on the PyUnicode C API (#159533) #159539
Merged
vstinner added a commit that referenced this pull request Oct 16, 2026
@vstinner
[3.14] gh-156939: Add tests on the PyUnicode C API (#159533) (#159539)
21aae35
[3.15] gh-156939: Add tests on the PyUnicode C API (#159533)

* gh-142217: Add tests on the deprecated _Py_Identifier C API (#157638)

(cherry picked from commit 21403af)

* gh-156939: Add tests on the PyUnicode C API (#157798)

Add tests on functions:

* PyUnicode_CHECK_INTERNED()
* PyUnicode_Check()
* PyUnicode_CheckExact()
* PyUnicode_Equal()
* PyUnicode_GET_LENGTH()
* PyUnicode_IS_ASCII()
* PyUnicode_IS_COMPACT()
* PyUnicode_IS_COMPACT_ASCII()
* PyUnicode_KIND()
* PyUnicode_MAX_CHAR_VALUE()
* PyUnicode_READ()
* PyUnicode_READ_CHAR()
* PyUnicode_WRITE()

Changes:

* Add test on PyUnicode_FromOrdinal(0).
* Require _testcapi module in test_capi.test_unicode. Since _testcapi
  is specific to CPython, remove @support.cpython_only.

(cherry picked from commit e8f6448)
(cherry picked from commit bcbe9bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.