GeezerVison is showing github.com — gh-150097: Move _testclinic to multi-phase init by cmaloney · Pull Request #157968 · python/cpython
Conversation
cmaloney
commented
Sep 22, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Drop the Argument Clinic (AC) vectorcall requirement for static types and convert the existing test cases to heap types. Move empty init vectorcall to share with existing no-arg __init__ case. Add support for no-argument vectorcall so the no-arg __init__ cases actually work (rather than adding an arg). Produce the same error string as the PyArg helpers do.
The AC vectorcall types no longer have a C address for the generated Py_Is so instead compare the slot function instead.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Convert the static types to heap types. Move empty init vectorcall to
share with existing no-arg __init__ case. Add support for no-argument
vectorcall so the no-arg __init__ cases actually work (rather than
adding an arg). Produce the same error string as the PyArg helpers do.
The vectorcall types no longer have a C address for the generated
`Py_Is` so instead compare the slot function instead. This drops the
requirement that a class using vectorcall declare a type object.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
This was referenced Sep 22, 2026
and convert the existing test cases to heap types
Maybe you should add tests for heap types instead?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
skirpichev
pushed a commit
to skirpichev/cpython
that referenced
this pull request
Sep 26, 2026
Convert the static types to heap types. Move empty init vectorcall to
share with existing no-arg __init__ case. Add support for no-argument
vectorcall so the no-arg __init__ cases actually work (rather than
adding an arg). Produce the same error string as the PyArg helpers do.
The vectorcall types no longer have a C address for the generated
`Py_Is` so instead compare the slot function instead. This drops the
requirement that a class using vectorcall declare a type object.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
(cherry-picked from python#157968)
…tclinic-multiphase
# Conflicts:
# Modules/clinic/_testclinic.c.h
…tclinic-multiphase
# Conflicts:
# Tools/clinic/libclinic/parse_args.py
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.