GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. by serhiy-storchaka · Pull Request #15824 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 10, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Use the const qualifier for constant C strings.
  • Intern field and attribute names.
  • Temporary incref a borrowed reference to a list item.

https://bugs.python.org/issue38083

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-38083: Minor improvements in asdl_c.py and Python-ast.c.
0301c3d 
* Use the const qualifier for constant C strings.
* Intern field and attribute names.
* Temporary incref a borrowed reference to a list item.
@serhiy-storchaka serhiy-storchaka added the skip news label Sep 10, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 10, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 10, 2019
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 10, 2019
bpo-36876: Make some static string literal arrays constant. #15760
Closed
@Yhg1s
Yhg1s merged commit 43c9731 into python:master Sep 10, 2019
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 10, 2019
@serhiy-storchaka
serhiy-storchaka deleted the python-ast branch October 7, 2019 17:01
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@serhiy-storchaka @websurfer5
bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. (pythonG…
f6eb6c2 
…H-15824)

* Use the const qualifier for constant C strings.
* Intern field and attribute names.
* Temporary incref a borrowed reference to a list item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @Yhg1s @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.