GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-158322: Tidy docstrings in `turtle` module by StanFromIreland · Pull Request #158281 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Sep 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the first round of what will probably be quite a few PRs, as I want to keep the diff in each one reasonably small.

With the introduction of turtle-translations, I’d like to improve the existing docstrings so that they produce better translations. Along the way, this PR also includes a handful of ad hoc refactors that I noticed while working through the module.

These could reasonably be classified as churn, however, the turtle module is, frankly, quite messy in places. I think these changes improve readability and, as a result, maintainability, so I intend to tidy up similar issues.

They should also have relatively little impact on useful Git history, since the majority of the affected lines date back to the original port in 97cf99f.

If there are no comments, I plan to merge this next Thursday.

  • Issue: Modernize the turtle module #158322

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
StanFromIreland added 2 commits September 27, 2026 12:34
@StanFromIreland
Tidy docstrings in turtle module
ace76f3
@StanFromIreland
A few more things for this round
8f45866
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 27, 2026
@StanFromIreland StanFromIreland added skip issue skip news type-refactor Code refactoring (with no changes in behavior) and removed awaiting core review labels Sep 27, 2026
@StanFromIreland StanFromIreland added this to Turtle issues 🐢 Sep 27, 2026
@StanFromIreland
StanFromIreland requested review from m-aciek and willingc September 27, 2026 11:50
@StanFromIreland StanFromIreland added the awaiting core review label Sep 27, 2026
m-aciek
m-aciek approved these changes Sep 27, 2026
View reviewed changes

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/turtle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland changed the title Tidy docstrings in turtle module gh-158322: Tidy docstrings in turtle module Sep 28, 2026
@StanFromIreland StanFromIreland removed the skip issue label Sep 28, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 28, 2026
Modernize the turtle module #158322
Open
@StanFromIreland StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 28, 2026
@StanFromIreland
StanFromIreland merged commit 4e9ea68 into python:main Sep 28, 2026
68 of 69 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland deleted the turtle/tidy-docstrings-round-1 branch September 28, 2026 08:42
@miss-islington-app

miss-islington-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 28, 2026
@StanFromIreland

StanFromIreland commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e9ea689fec273b9f848a648a62eba74a0216dfe 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158324 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 28, 2026
@miss-islington-app miss-islington-app Bot assigned StanFromIreland Sep 28, 2026
@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158325 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 28, 2026
@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158326 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 28, 2026
StanFromIreland added a commit that referenced this pull request Sep 28, 2026
@StanFromIreland
[3.13] gh-158322: Tidy up some docstrings in turtle module (GH-158281…
624a6a8 
…) (#158326)

(cherry picked from commit 4e9ea68)
StanFromIreland added a commit that referenced this pull request Sep 28, 2026
@miss-islington @StanFromIreland
[3.14] gh-158322: Tidy up some docstrings in turtle module (GH-158281)
6211b03 
(cherry picked from commit 4e9ea68)

Co-authored-by: Stan Ulbrych <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 28, 2026
@miss-islington @StanFromIreland
[3.15] gh-158322: Tidy up some docstrings in turtle module (GH-158281…
c08cf02 
…) (#158324)

Co-authored-by: Stan Ulbrych <[email protected]>
@StanFromIreland StanFromIreland mentioned this pull request Oct 1, 2026
gh-157847: Improve more turtle docstrings and docs #158562
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-aciek m-aciek m-aciek approved these changes
@willingc willingc Awaiting requested review from willingc

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@StanFromIreland StanFromIreland

Labels

skip news type-refactor Code refactoring (with no changes in behavior)

Projects

Turtle issues 🐢
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@StanFromIreland @m-aciek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.